Skip to content

HD haptics minor playback fixes - #1020

Open
Mac898 wants to merge 1 commit into
isXander:mainfrom
Mac898:pr/hd-haptics-clip-length
Open

Mac898 wants to merge 1 commit into
isXander:mainfrom
Mac898:pr/hd-haptics-clip-length

Conversation

@Mac898

@Mac898 Mac898 commented Nov 18, 2026

Copy link
Copy Markdown

Fixes three small issues with the playback logic inside the HD Haptics system for DualSense controllers.

  1. The clip length was calculated by integer division which reduced clips shorter than 1 second to 0 ticks, causing the next clip to be appended to the previous one instead of getting it's own stream.

  2. Sounds that aren't cached at the time of playback were loaded on a background thread, which could cause the driver's stream list to be updated while the client thread was also working on it.

  3. updateHDHaptic removed an expired stream by index inside a loop, causing the next stream to be skipped.

Fixes:

  1. Round up to a minimum of one tick

  2. Playback runs on the client thread with Minecraft.execute

  3. Switch to an iterator.

Testing:
Verified on Linxu with a wired DualSense controller and Controlify's built-in haptics. Builds and tests pass on 26.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant