Skip to content

properly gate bannable gameplay fixes #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Wyvest wants to merge 2 commits into
base: archive/1.21.5
Choose a base branch
from
Open

properly gate bannable gameplay fixes #562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f5d498
move MC-231097 to gameplay, and add fix explanation and effect; it ca…
Wyvest Sep 3, 2026
99224ab
properly gate bannable gameplay fixes
Wyvest Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/client/java/dev/isxander/debugify/client/DebugifyClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import dev.isxander.debugify.Debugify;
import dev.isxander.debugify.client.utils.BugFixDescriptionCache;
import dev.isxander.debugify.client.utils.ClientUtils;

public class DebugifyClient {
public static BugFixDescriptionCache bugFixDescriptionCache;
Expand All @@ -13,6 +14,6 @@ public static void onInitializeClient() {
}

public static boolean isGameplayFixesEnabled() {
return Debugify.CONFIG.gameplayFixesInMultiplayer;
return !ClientUtils.isInMultiplayerWorld() || Debugify.CONFIG.gameplayFixesInMultiplayer;
}
}
7 changes: 4 additions & 3 deletions ...xins/basic/mc231097/LocalPlayerMixin.java → ...s/gameplay/mc231097/LocalPlayerMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package dev.isxander.debugify.client.mixins.basic.mc231097;
package dev.isxander.debugify.client.mixins.gameplay.mc231097;

import dev.isxander.debugify.client.DebugifyClient;
import dev.isxander.debugify.fixes.BugFix;
import dev.isxander.debugify.fixes.FixCategory;
import net.minecraft.client.Minecraft;
Expand All @@ -11,7 +12,7 @@
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;

@BugFix(id = "MC-231097", category = FixCategory.BASIC, env = BugFix.Env.CLIENT)
@BugFix(id = "MC-231097", category = FixCategory.GAMEPLAY, env = BugFix.Env.CLIENT)
@Mixin(LocalPlayer.class)
public abstract class LocalPlayerMixin {
@Shadow @Final protected Minecraft minecraft;
Expand All @@ -20,7 +21,7 @@ public abstract class LocalPlayerMixin {

@Inject(method = "drop", at = @At(value = "INVOKE", target = "Lnet/minecraft/world/entity/player/Inventory;removeFromSelected(Z)Lnet/minecraft/world/item/ItemStack;", shift = At.Shift.AFTER))
private void onDropItem(boolean entireStack, CallbackInfoReturnable<Boolean> cir) {
if (isUsingItem()) {
if (isUsingItem() && DebugifyClient.isGameplayFixesEnabled()) {
minecraft.gameMode.releaseUsingItem((LocalPlayer) (Object) this);
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/client/resources/debugify.client.mixins.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"basic.mc217716.GameRendererMixin",
"basic.mc22882.AbstractContainerScreenMixin",
"basic.mc22882.MinecraftMixin",
"basic.mc231097.LocalPlayerMixin",
"gameplay.mc231097.LocalPlayerMixin",
"basic.mc237493.OptionsMixin",
"basic.mc237493.TelemetryEventInstanceMixin",
"basic.mc237493.TelemetryEventWidgetMixin",
Expand Down
2 changes: 2 additions & 0 deletions src/main/resources/assets/debugify/lang/en_us.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@
"debugify.fix_explanation.mc-176559": "Does not consider item durability when comparing a change in item when checking if block breaking should reset.",
"debugify.fix_explanation.mc-197260": "Overrides the light level passed to the armour stand renderer with a maximum of: the block below the armor stand, bottom of the armor stand, top of the armor stand and the block above of the armor stand.",
"debugify.fix_explanation.mc-237493": "Adds an option in the telemetry menu to completely disable telemetry. Telemetry is disabled by overriding all outgoing telemetry events to be an empty telemetry event, which is not sent.",
"debugify.fix_explanation.mc-231097": "When dropping an item, the client will send a \"release using item\" packet, if the player is currently using an item.",
"debugify.fix_effect.mc-231097": "This can cause very strict anti-cheats, such as Anti-Gaming-Chair, to flag \"invalid packet order\", which may result in a ban.",

"debugify.fix_explanation.mc-2025": "Due to floating point inaccuracies, sometimes the hitbox of entities end up being slightly smaller than desired. Then, if this happens before the entities are pushed against eachother, they will intersect with the wall. Then, when the AABB is recalculated on chunk load, they will be determined as inside the wall, where they are then pushed. This fix simply writes an 'AABB' tag to entity NBT data with double-precision hitbox sizes which then get loaded back in.",
"debugify.fix_effect.mc-2025": "This fix means loading Debugify for the first time will not fix the issue until the chunks are saved and loaded with Debugify.",
Expand Down