Repository navigation
Replace erroneous use of overflow - #2341
Merged
Merged
Conversation
jwakely
reviewed
Oct 16, 2026
|
|
||
| Use unsigned types if you really want modular arithmetic - add | ||
| comments as necessary noting the reliance on overflow behavior, as such code | ||
| comments as necessary noting the reliance on modulo behavior, as such code |
Contributor
There was a problem hiding this comment.
The change is of course correct, but I wonder if it would be more friendly to casual readers like so:
Suggested change
| comments as necessary noting the reliance on modulo behavior, as such code | |
| comments as necessary noting the reliance on modulo behavior, i.e. wrapping to zero, as such code |
Contributor
Author
There was a problem hiding this comment.
Or just
Suggested change
| comments as necessary noting the reliance on modulo behavior, as such code | |
| comments as necessary noting the reliance on wrapping behavior, as such code |
?
Contributor
Author
There was a problem hiding this comment.
Changed and green now.
johnmcfarlane
force-pushed
the
patch-2
branch
from
October 20, 2026 10:14
ac12980 to
639acf9
Compare
johnmcfarlane
force-pushed
the
patch-2
branch
from
October 26, 2026 15:15
f025e78 to
692c438
Compare
Modulo behaviour of unsigned integers appears to be referred to as overflow. However, [unsigned integers don't overflow](https://eel.is/c++draft/basic.fundamental#note-1). Replaced "overflow behavior" with "wrapping behavior".
johnmcfarlane
force-pushed
the
patch-2
branch
from
October 26, 2026 18:21
692c438 to
8d35dfc
Compare
jwakely
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modulo behaviour of unsigned integers appears to be referred to as overflow. However, unsigned integers don't overflow. Replaced "overflow behavior" with "modulo behavior".