Repository navigation
Version 0.2.12: keep Tiny server on the rail, and stop asking for the keychain password after an update. - #66
Merged
Merged
Conversation
… keychain password after an update. The Tiny server mark declared its own size, and the rail added a second one. The SVG was invalid, so the button drew nothing. A network whose session is still in the keychain stays on the rail while that read is waiting or refused. An ad-hoc release's designated requirement is only its cdhash, so each update asked for the login password once per network. After chatd reads or writes an item, any app on this Mac can read it without asking. The keychain still locks when the person is logged out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Tiny server disappeared from the rail in 0.2.11, and every restart asked for the Mac login password once per signed-in network.
The Tiny server mark already declared
widthandheight. The rail added a second pair. The SVG parser rejects that, so the button drew nothing.The rail only lists a network whose live link is not signed out. While chatd is still reading that network's keychain item, or the prompt was canceled, the account stays in the database but the rail dropped it.
The installed app is ad-hoc signed. That signature's designated requirement is only its cdhash, so each update is a different app and macOS asks for the login password once per keychain item.
What changed
This update asks one last time, while it opens the existing items. Later launches do not.
Tests
a_sized_icon_declares_its_drawn_size_oncea_stored_account_stays_on_the_rail_while_its_session_is_unread