Skip to content

Fix coroutines property name in build.gradle - #445

Open
lamtrinhdev wants to merge 2 commits into
ivpn:developfrom
lamtrinhdev:Fix_build.gradle
Open

lamtrinhdev wants to merge 2 commits into
ivpn:developfrom
lamtrinhdev:Fix_build.gradle

Conversation

@lamtrinhdev

Copy link
Copy Markdown

PR type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other... Please describe:

Description

While reviewing the Gradle config, I noticed the coroutines version property in the root build.gradle was misspelled as coroutenes. It still worked since the same (misspelled) name was used everywhere, but it's confusing for anyone searching for the property by its correct name, and it could silently break if someone later adds a properly spelled coroutines property alongside it.

This PR renames the property to coroutines and updates all references. No dependency versions are changed.

Changes

  • build.gradle — rename coroutenes → coroutines in the root ext block
  • core/build.gradle — update the 2 dependency references (kotlinx-coroutines-core, kotlinx-coroutines-android) to use the renamed property

@lamtrinhdev

Copy link
Copy Markdown
Author

Dear @jurajhilje ,

I have some update for build.gradle and core/build.gradle. When you have time, please help me to review it.

Thanks,
Lam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant