Repository navigation
Remove dead ant-deb toolchain - #721
Merged
Merged
Conversation
The .deb packages are built with NBPackage via installers/build-installers.sh (since PR jMonkeyEngine#660 replaced NBI). The ant-deb-task jar, the orphaned ant-googlecode upload jar (unused since 2013), the debscripts/postrm hook and the corresponding taskdefs in build.xml have no remaining users. This resolves the original goal of issue jMonkeyEngine#449 (distribute the SDK as a .deb): .deb artifacts for amd64 and arm64 have shipped with every GitHub release since v3.8.0. A signed apt repository is added separately. Closes jMonkeyEngine#449 Co-authored-by: neph1 <neph1@users.noreply.github.com>
jaime-jmebot
approved these changes
Oct 25, 2026
jaime-jmebot
left a comment
There was a problem hiding this comment.
- Clean removal of legacy, unused ant-deb toolchain and associated orphaned files.
- Build configuration properly updated and verified.
- Looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ant-lib/ant-deb.jar(ant-deb-task, 2010)ant-lib/ant-googlecode-0.0.3.jar(Google Code upload task, orphaned since commit 940ba3b in 2013)debscripts/postrm(old post-remove hook)deb/desktopentrytaskdefs inbuild.xml:14-15installers/build-installers.shsince PR Replace NBI with NBPackage #660 ("Replace NBI with NBPackage"), and.debartifacts for amd64 + arm64 have shipped with every GitHub release since v3.8.0.apt installdistribution is handled in a separate PR.Verification
grep -rn "ant-deb\|ant_deb\|ant-googlecode\|debscripts\|googlecode"overbuild.xml,nbproject/,installers/,.github/,ant-jme/returns no remaining references (only historical doc HTML underjme3-documentation/mentions googlecode, untouched).build.xmlstill parses as well-formed XML after removing the taskdefs.ant-lib/jars (ant-contrib.jar,ant-jme.jar) are still in use (foreach/if/updatenbdepsinbuild.xml).Closes #449