Repository navigation
ci: gate fork followers on artifact presence, not actor - #360
Merged
AndreasIgel merged 1 commit intoOct 22, 2026
Merged
Conversation
SonarCloud githubactions:S8232 flags gating job execution on forgeable github.event.workflow_run context (actor.login). Gate on a fact of the completed run instead: a gate job checks whether the CI run produced its artifact (sonar-analysis-inputs / codecov-payload) via the Actions API, and the real job only runs through needs: when it exists. This covers any skipped CI run - including the ones the igel-devin-ai actor guard produces - rather than just that actor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two
githubactions:S8232MAJOR findings SonarCloud reported on #357's merge: the jobifusedgithub.event.workflow_run.actor.login, a forgeable event context value, for a trust decision.Fix: instead of checking who triggered the run, gate on what it produced. A small gate job in
fork-sonar.yml(analysis-inputs) andfork-coverage.yml(coverage-payload) lists the completed CI run's artifacts via the Actions API and outputspresent; the real job runs throughneeds:only when the artifact exists and is unexpired.This subsumes the previous actor check and is more correct generally: any skipped
buildjob (not just igel-devin-ai'sopenedruns) concludessuccessbut produces no artifacts, so the followers now skip cleanly in every such case. jq logic verified locally (present / absent / expired-artifact cases).