Repository navigation
fix(go): make and the pre-push hook run the pinned toolchain - #150
Merged
Merged
Conversation
Under a system Go 1.27 the pre-push hook failed TestDecodeNamesJSONTypes on a clean main, so every run needed GOTOOLCHAIN exported by hand. The Makefile and scripts/check-fast.sh now set GOTOOLCHAIN to go.mod's version (+auto) unless one is already set, so a local go of another version runs the pinned one. The test was right: Go 1.27 no longer names the field of a type error that a field's own UnmarshalJSON returns (validate.Nullable), so the API answered " must be a string". validate.DecodeInto now finds that field itself, in web and admin, so the message holds on either Go. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jayleaton
force-pushed
the
fix/pinned-toolchain
branch
from
November 1, 2026 13:03
1d94c87 to
607773c
Compare
Owner
Author
|
Merged with admin override; review requirement waived by JJ (authorized 2026-11-01) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With a system Go other than go.mod's (here Go 1.27),
make check-fastand the pre-push hook failTestDecodeNamesJSONTypeson a cleanmain: Go 1.27 no longer names the field in a type error returned by a field's ownUnmarshalJSON(validate.Nullable), so the API answered" must be a string". Every run neededGOTOOLCHAINexported by hand.Fix
Makefileandscripts/check-fast.shsetGOTOOLCHAINto go.mod's version (+auto) unless one is already set, so a localgoof another version runs the pinned one.validate.DecodeInto(web and admin) finds the field of such a type error itself, so the message is right on either Go.Follows #149 (it will be rebased onto
mainonce that merges).Local verification
Head
607773cf20c18018991d4581d785a96493471b97· treeee116c7ee8ad· passedAttested by
JJ EatononStudio-01Ran: make ci-pg (make ci, make check-migrations, release smoke on a throwaway Postgres 18) and make check-fast, with the system Go 1.27 and no GOTOOLCHAIN set
🤖 Generated with Claude Code