Extend operator support - #282
Draft
jbcoe wants to merge 6 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
==========================================
+ Coverage 72.87% 72.95% +0.08%
==========================================
Files 9 9
Lines 822 832 +10
Branches 208 208
==========================================
+ Hits 599 607 +8
- Misses 24 25 +1
- Partials 199 200 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jbcoe
commented
Sep 2, 2026
| // <source-name> for its identifier otherwise. `identifier_of` throws for | ||
| // `operator()`, which has no identifier. | ||
| // <operator-name> for a supported operator function, or a length-prefixed | ||
| // <source-name> for its identifier otherwise. `identifier_of` throws for an |
Owner
Author
There was a problem hiding this comment.
Rephrase "identifier_of` throws for an operator function, which has no identifier."
jbcoe
commented
Sep 2, 2026
| consteval bool same_name(std::meta::info a, std::meta::info b) { | ||
| if (is_call_operator(a) || is_call_operator(b)) | ||
| return is_call_operator(a) && is_call_operator(b); | ||
| bool a_is_operator = is_operator_function(a); |
jbcoe
commented
Sep 2, 2026
| // viewed/owned object. | ||
| R operator()(Args... args) noexcept(IsNoexcept) | ||
| protected: | ||
| // Widens the EnclosingType pointer to the enclosing protocol/protocol_view |
jbcoe
commented
Sep 2, 2026
| #ifndef XYZ_REFLECTION_OPERATORS_H_ | ||
| #define XYZ_REFLECTION_OPERATORS_H_ | ||
|
|
||
| // The overloadable operators a protocol interface may declare as member |
Owner
Author
There was a problem hiding this comment.
Condense this comment block.
jbcoe
commented
Sep 2, 2026
| EXPECT_EQ(p[21], 42); | ||
| } | ||
|
|
||
| // Other operator tests for protocol. These exercise the operator table: a |
Owner
Author
There was a problem hiding this comment.
This comment block is unneccesary.
jbcoe
commented
Sep 2, 2026
| // function's signature (see "name_mangling.h"), so an entry can be found by | ||
| // the signature it implements rather than by declaration order. | ||
| // | ||
| // Neither implementation currently supports operators other than operator(). |
jbcoe
commented
Sep 2, 2026
| // or `operatorX` for an operator function, which has no identifier. | ||
| consteval std::string function_display_name(std::meta::info function) { | ||
| if (has_identifier(function)) return std::string(identifier_of(function)); | ||
| return "operator" + std::string(symbol_of(operator_of(function))); |
Owner
Author
There was a problem hiding this comment.
Q: Why do we need operatorX?
jbcoe
commented
Sep 2, 2026
| // Which operator a thunk exposes for its call syntax. A named interface member | ||
| // is reached through its enclosing `member_base`'s named data member and so is | ||
| // dispatched through `operator()`; an operator interface member is reached | ||
| // directly and uses the operator it declares. |
Owner
Author
There was a problem hiding this comment.
Q: What does 'directly' mean here?
jbcoe
commented
Sep 2, 2026
| // Widens the EnclosingType pointer to the enclosing protocol/protocol_view | ||
| // object, then calls through its stored vtable pointer's matching function | ||
| // pointer, passing the viewed/owned object. | ||
| R dispatch(Args... args) noexcept(IsNoexcept) |
Owner
Author
There was a problem hiding this comment.
I think we still need operator() on the thunks? Renaming this is misleading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.