Repository navigation
Conversation
The main ruleset requires linear history and CI checks instead of pull requests, so a fast-forward release needs no bypass unless dev contains merge commits. Merging main back into dev after a squash added one (1314e20) and made the v0.6.1 push need the admin bypass.
… marks all assets missing The V3 Lookup API fails a whole batch with V3API_LookupError_012 when any item is missing. Since 0.5.5 release plan sent all non-Connection assets in one batch and treated that error as "everything missing", so only Connections were reported found and the missing-transitive filter kept transitive assets that already exist in the target. A failed batch is now bisected until the missing assets are isolated, lookups are chunked at 200 assets, other errors stay "unknown", and each target logs found/missing/unknown counts and the Lookup call count. The test fake now fails batches the way the real API does.
… connections Bisecting a failed Lookup batch took more calls than one per asset when many assets were missing (906 calls for 761 assets against tst). The V3API_LookupError_012 message lists every missing object, so those are marked missing and the rest is looked up again; bisection remains the fallback. On ClaimCenter_Conversion (1311 assets) target checks now take 21 calls and 36 s, against about 17.5 min in v0.5.3, with the same plan. HTTP 429 responses are retried up to 3 times, waiting as Retry-After or ratelimit-reset says, or 2/4/8 s with jitter. An asset still rate limited is reported missing with an APIRateLimitError warning so it stays in the package. Read-only requests (GET, Lookup) are resent up to 2 times on EOF or connection reset, which left assets unknown in long runs. Requests that change data are never resent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch release v0.6.2: fixes
release planreporting every non-Connection asset as missing in a target (regression since v0.5.5), and adds API retries for rate limits and dropped connections.Merge method: fast-forward (dev pushed to main, all commits kept).
Changed
comes from the
Retry-Afterorratelimit-resetheader (capped at 60seconds), or is an exponential backoff of 2, 4 and 8 seconds plus jitter
when the response has neither. In
release plan, an asset whose lookup isstill rate limited is reported
missingwith anAPIRateLimitErrorwarning, so it stays in the package.
when the connection drops (
EOFor connection reset). In longrelease planruns these drops left assets with statusunknown.Requests that change data are never resent.
Fixed
all assets missing. Since 0.5.5,
release planreported everynon-Connection asset as
missingin a target when any one asset wasmissing there, which also kept transitive dependencies that already exist
in the target. The assets named in the error are now marked missing and
the rest of the batch is looked up again (the batch is split in half when
the error cannot be matched), with batches capped at 200 assets. A
200-asset batch usually takes one or two Lookup calls.
🤖 Generated with Claude Code