Repository navigation
JITSU-260: enforce connector images and supervise isolated sync shutdown - #1602
Merged
Merged
Conversation
sahiltyagi-jitsu
marked this pull request as ready for review
October 27, 2026 07:42
absorbb
force-pushed
the
fix/jitsu-260-sync-pod-isolation
branch
from
October 30, 2026 15:55
5515f9b to
db5999d
Compare
absorbb
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JITSU-260(T2), part ofJITSU-250.Connector Pods retain unconditional process isolation from the merged security fix. This change adds image enforcement in syncctl and an optional, per-sync supervisor that shortens the time a connector can continue after lease loss.
Behavior
shareProcessNamespace: falseremains unconditional. There is no isolation-disable flag and no cross-container PID 1 signaling.SYNCCTL_SYNC_ALLOWED_IMAGE_PREFIXESchecks manual spec/check/discover/read before creating a Pod or Secret, and checks scheduled syncs during CronJob reconciliation. Empty preserves compatibility. Disallowed scheduled syncs lose their CronJob; inventory required images before enabling enforcement.SYNCCTL_SYNC_FAST_SHUTDOWN_IDSselects exact comma-separated sync IDs for canary rollout; empty keeps existing controller cleanup, and*enables supervision for all connector tasks. This setting never changes isolation./shared/terminateand the source supervisor exits promptly, terminating that container's PID namespace. Ordinary SIGTERM/SIGINT is forwarded to the connector entrypoint and the supervisor waits for graceful exit; kubelet retains the configured termination deadline.Validation
go test -short ./sync-controller ./sync-sidecarpasses.Rollout and limits
Deployment remains manual. First publish updated syncctl/sidecar and update the sidecar image while fast-shutdown IDs remain empty. Review the image inventory before enabling the allowlist. Then enable fast shutdown for one disposable test sync, validate a real connector through completion/cancellation/lease takeover, and expand the selected IDs before using
*.See ISOLATION_ROLLOUT.md for inventory commands, rollout, rollback and tests. Existing Pods are not retrofitted. Clearing the fast-shutdown list rolls back supervision while keeping isolation. Connector entrypoints must forward graceful termination to subprocesses.
This revision has not been deployed or validated through a complete real Airbyte sync/Kubernetes lease takeover. The shared marker is coordination, not a hostile-code boundary; controller cleanup remains necessary.