Repository navigation
Avoid copying arrays when checking their type - #135
Merged
Merged
Conversation
GrahamCampbell
force-pushed
the
avoid-array-copy-in-type-checks
branch
from
November 17, 2026 00:17
a9870d9 to
83468d6
Compare
GrahamCampbell
force-pushed
the
avoid-array-copy-in-type-checks
branch
from
November 17, 2026 01:38
83468d6 to
1c3e72e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Utils::type() called reset() on its by-value argument, which makes PHP copy the whole array first, and Utils::isArray() and Utils::isObject() built the complete list of keys in order to look at the first one. Every validated function argument, every element compared by max_by() and min_by(), and every index and slice therefore cost time and memory in proportion to the size of the array, so
length(@)on an object with a million members took several milliseconds and about 40 MB. All three now stop at the first key without copying the array or listing its keys, and classify every value exactly as before. There is no change in behaviour, and this is intended for 2.10.0.