Skip to content

Raise the minimum polyfill-mbstring version - #137

Merged
GrahamCampbell merged 1 commit into
2.10from
raise-polyfill-mbstring-floor
Nov 17, 2026
Merged

GrahamCampbell merged 1 commit into
2.10from
raise-polyfill-mbstring-floor

Conversation

@GrahamCampbell

Copy link
Copy Markdown
Collaborator

This package relies on symfony/polyfill-mbstring whenever the mbstring extension is not loaded, a path the official PHP 8.6 Docker image now takes by default, since as of 8.6.0RC7 it no longer bundles the extension. The existing ^1.17 constraint allows polyfill releases whose own code triggers PHP deprecations on that path. Every release up to 1.25 passes null to preg_split inside mb_str_split, which has been deprecated since PHP 8.1 and is reached by reverse() and string slicing, and 1.28 and 1.29 declare an implicitly nullable parameter on mb_str_pad, which has been deprecated since PHP 8.4. Every release from 1.30 onwards is clean and remains installable on every PHP version this package supports, so this raises the floor to ^1.30 and records the change in the changelog.

@GrahamCampbell
GrahamCampbell marked this pull request as ready for review November 17, 2026 02:42
@GrahamCampbell
GrahamCampbell merged commit 8b42a22 into 2.10 Nov 17, 2026
44 checks passed
@GrahamCampbell
GrahamCampbell deleted the raise-polyfill-mbstring-floor branch November 17, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant