Repository navigation
Raise the minimum polyfill-mbstring version - #137
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package relies on symfony/polyfill-mbstring whenever the mbstring extension is not loaded, a path the official PHP 8.6 Docker image now takes by default, since as of 8.6.0RC7 it no longer bundles the extension. The existing
^1.17constraint allows polyfill releases whose own code triggers PHP deprecations on that path. Every release up to 1.25 passes null topreg_splitinsidemb_str_split, which has been deprecated since PHP 8.1 and is reached byreverse()and string slicing, and 1.28 and 1.29 declare an implicitly nullable parameter onmb_str_pad, which has been deprecated since PHP 8.4. Every release from 1.30 onwards is clean and remains installable on every PHP version this package supports, so this raises the floor to^1.30and records the change in the changelog.