Repository navigation
fix(ci): leave uv.lock to the Upgrade lock workflow, not Dependabot - #24
Merged
Merged
Conversation
Remove the uv ecosystem from the Dependabot config. Since v1.3.0 the monthly Upgrade lock workflow runs uv lock --upgrade, which covers everything Dependabot's uv update does plus the newest release for each supported Python, and the two pull requests conflict. Dependabot keeps GitHub Actions and pre-commit hooks. The README, the generated CONTRIBUTING.md and the comments that said Dependabot updates uv.lock now say the workflow does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What to check
template/.github/dependabot.ymlhas onlygithub-actionsandpre-commitnow; theuventry is gone.uv.lock(README row, generatedCONTRIBUTING.md"Dependency updates", two comments) now say the Upgrade lock workflow does.uv.lock) is kept in the workflow's header comment and one paragraph ofCONTRIBUTING.md.What changed
Since v1.3.0 the monthly Upgrade lock workflow (
uv lock --upgrade) and Dependabot's monthly uv update both open auv.lockpull request, and the two conflict. The workflow covers everything Dependabot's does and also the newest release for each supported Python, so Dependabot's uv entry is removed. Dependabot keeps GitHub Actions and pre-commit hooks (grouped, monthly, 7-day cooldown, unchanged). No cooldown is added to the workflow and noexclude-newer.template/.github/dependabot.yml: delete theuventry; the header saysuv.lockis the workflow's.template/.github/workflows/lock-upgrade.yml.jinja: header comment says the workflow is the only thing that updatesuv.lock.template/CONTRIBUTING.md.jinja: "Dependency updates" says Dependabot does actions and hooks, the workflow doesuv.lock.template/.pre-commit-config.yaml: comment "Dependabot does it" now names the workflow.README.md: the Upkeep row.Left as they were because they are still true: the comment in
template/.github/zizmor.yml(Dependabot keeps action tags current), the rootCONTRIBUTING.mdline aboutastral-sh/setup-uv, and theruff and pyrefly come from uv.lockcomment independabot.yml.template/AGENTS.md.jinjaand the after-copy message incopier.ymlmake no Dependabot claim.Checked
just teston a compute node (both variants, every check including the zizmor hook and all pre-commit hooks): "All checks passed for both variants.".github/dependabot.yml, the "Dependency updates" section ofCONTRIBUTING.mdand every remaining mention of Dependabot.gh pr listfor open Dependabot pull requests in the seven packages: none open.Not checked
copier updatewith this change; GitHub's behavior on a repository whose Dependabot config lacks the uv entry (an open Dependabot uv pull request, if any, is not closed by removing the entry; none is open in the seven packages today).