Repository navigation
Analyse phpstan across all supported PHP versions - #66
Merged
Merged
Conversation
Without phpVersion, PHPStan takes config.platform.php from composer.json when set, so it only analysed for the pinned version. Set the supported range explicitly so code that needs a newer PHP than the minimum is still reported. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G1B1haEbMV4nwwwdJ4yxmY
There was a problem hiding this comment.
🟢 Approval recommended
The configuration is valid and matches the repository’s documented and tested PHP support range.
0 open findings
What changed in this PR
Configures PHPStan to analyze the library across its supported PHP 8.3–8.5 range.
Changes:
- Sets PHPStan’s minimum version to PHP 8.3.
- Sets its maximum version to all PHP 8.5 patch releases.
| File | Description |
|---|---|
phpstan.neon |
Adds the supported PHP version range for static analysis. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #63. When
phpVersionisn't set, PHPStan takes the PHP version fromcomposer.json, andconfig.platform.php(now pinned to8.3.0for Dependabot) wins overrequire.php. So phpstan only analysed for PHP 8.3, instead of the full supported range.This sets
phpVersiontomin: 80300/max: 80599inphpstan.neon, so the analysis covers every PHP version the library supports, whatever the platform pin says.🤖 Generated with Claude Code
https://claude.ai/code/session_01G1B1haEbMV4nwwwdJ4yxmY
Generated by Claude Code