Repository navigation
Add a demo website that runs the validator in the browser with WebAssembly - #12
Merged
Merged
Conversation
lyrixx
marked this pull request as ready for review
November 13, 2026 18:56
Member
|
Thanks for the contribution! I am merging this PR now. The PR #13 complements it and will be merged in a few minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds
website/, a static page that runs the validator in the browser: PHP is built as WebAssembly with lyrixx/php-wasm-builder, with the library of the working directory embedded.castor website:build,website:checkandwebsite:servebuild, test and serve it, and a new workflow deploys it to GitHub Pages frommain.Why
asked on a private repo
Validating a URL is not there: a page can only read another website when that website allows it with CORS headers, and almost none does for its pages. PHP has no network of its own in WebAssembly, so it would go through the same
fetch(). It would need a proxy, so a server.To do after the merge: in the settings of the repository, GitHub Pages must deploy from GitHub Actions.
Checklist
castor qa:phpunit:run): not run, the library is untouched.castor website:checkpasses.castor qa:cs)castor qa:phpstan): 2 errors insrc/JsonLd/Algorithms/Expand/Expander.phpon my machine, thatmainhas too.cc @xavierlacot