Simplify the streamed Silk lexer with current language features - #380
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #371 (
julia/self-hosted-stream-lexer).The streamed Silk lexer still used verbose bootstrap-era byte checks, cursor arithmetic, and duration flags. This refactor uses short-circuit predicates, contextually typed integer literals, an exhaustively matched literal-category enum, direct destructuring, and a duration-unit bitset. It removes the duplicated compound-punctuation precheck and shortens the lexer by 268 lines while preserving its output.
Remove the redundant
usizealias in the entry point and import the token writer explicitly, avoiding the collision between theTokentype and its module namespace.Also simplify the TypeScript bootstrap lexer with exhaustive duration-diagnostic matching, keyword length buckets, and shared punctuation classification. Extend its malformed-duration test to exercise the separator diagnostic and regenerate the compiler integrity digest.
Validation:
pnpm checkpassed, including the full compiler suite and shared native acceptance corpus.pnpm release:candidatepassed all 10 checks.