Repository navigation
fix: 保留签名恢复副本并修正工具预检与报告结果 - #106
Merged
Merged
Conversation
- 签名恢复目录在 apksigner 运行前创建于输出目录,不再放入 MCP 任务暂存根目录 - 回滚失败时 CLI keep 的恢复副本不会被 MCP 清理 - check-apk 支持 --apksigner;MCP 证书预检复用实际签名器路径 - 任务结果仅在保护报告实际存在时返回 report 字段 - 补充自定义签名器、缺失报告和恢复目录的回归测试
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
来源
修复
2026-11-12/MCP补充确认/补充报告.md中的 3 项问题。修复内容
P1 回滚失败后的恢复副本被 MCP 删除
apksigner之前创建于输出目录,而不是SHELLSMITH_STAGE_ROOT任务暂存目录recovery.keep()保留的恢复副本不在 MCP 任务临时目录内,MCP 退出/取消清理不会删除它report.json备份在两条路径下都仍然存在P2 自定义 apksigner 被证书预检忽略
shield check-apk新增--apksigner <JAR>,同时用于签名验证和证书指纹读取shellsmith_check_apk暴露可选apksignerprotect_apk证书预检优先使用sign.apksigner,其次使用顶层apksignerP2 普通签名返回不存在的报告路径
JobPlan新增期望报告路径;任务成功时只有文件实际存在才保留结果中的reportsign_apk、protect_apk、protect_aab统一使用该过滤.protection.json;已有报告仍会返回{output},没有report字段验证
cargo fmt --all --check-D warningscargo test -p shellsmith-mcp:19 passedcargo test -p shield-core:263 passed(新增恢复目录测试)cargo test -p shield-cli:22 passedpython3 -m unittest discover -s scripts/tests:48 passedreport.json备份均存在protect_apk预检通过report未实机验证