chore(dedup): bump shaded jacoco.core to 0.8.15 to raise the Java ceiling - #186
Merged
Conversation
…ling The ASM shaded into keploy-sdk.jar comes from this dependency, and it is an independent ceiling on the bytecode dynamic dedup can instrument — separate from the jacocoagent.jar in k8s-proxy's init image. While it sat on 0.8.12 it was the LOWER of the two, so it, not the agent, is what capped dedup at Java 22. Measured by building this module both ways and reading the shaded ASM out of each jar: jacoco.core 0.8.12 -> ASM declares V23 (JaCoCo officially supports Java 22) jacoco.core 0.8.15 -> ASM declares V27 (JaCoCo officially supports Java 26) The 0.8.12 row reproduces the "tops out at Opcodes.V23" note k8s-proxy carried, and shows why it was read one version too high: the highest version ASM DECLARES is its experimental one, which sits a release ahead of what it accepts by default. With this, the SDK's shaded ASM matches the agent's (both V27 / Java 26), so once a release carrying it is pinned as KEPLOY_SDK_VERSION, k8s-proxy can raise dedupinject.SDKShadedASMMaxJava to 26 and the effective ceiling — min(JaCoCoOfficialMaxJava, SDKShadedASMMaxJava) — becomes Java 26. Build and the module's tests pass unchanged against 0.8.15. Signed-off-by: Shubham Jain <shubham@keploy.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
org.jacoco:org.jacoco.coreinkeploy-sdk/pom.xmlfrom 0.8.12 → 0.8.15.Why
The ASM shaded into
keploy-sdk.jarcomes from this dependency, and it is an independent ceiling on the bytecode dynamic dedup can instrument — separate from thejacocoagent.jarin k8s-proxy's init image. Dedup needs both jars to read the app, so the lower one wins.While this sat on 0.8.12 it was the lower one. It, not the agent, is what capped dynamic dedup at Java 22.
Evidence
Built this module both ways and read the shaded ASM out of each jar:
jacoco.coreV23V27V27The 0.8.12 row reproduces the "tops out at
Opcodes.V23" note k8s-proxy carried, and shows why it was read one version too high: the highest version ASM declares is its experimental one, a release ahead of what it accepts by default.Effect
The SDK's shaded ASM now matches the agent's. Once a release carrying this is pinned as
KEPLOY_SDK_VERSION, k8s-proxy can raisededupinject.SDKShadedASMMaxJavato 26 and the effective ceiling —min(JaCoCoOfficialMaxJava, SDKShadedASMMaxJava)— becomes Java 26.k8s-proxy's build now verifies this automatically: it reads the real shaded ASM out of
keploy-sdk.jaron every image build and fails if the constant over-promises.Verification
mvn -pl keploy-sdk packageand the module's tests pass unchanged against 0.8.15.Follow-up
A release needs cutting so
KEPLOY_SDK_VERSIONcan be bumped ink8s-proxy/build/dedup-jars/build.sh.