Repository navigation
ci: build on Node 20 and publish releases from tags - #117
Closed
Pranav-Bobde wants to merge 1 commit into
Closed
Pranav-Bobde wants to merge 1 commit into
Pranav-Bobde wants to merge 1 commit into
Conversation
- CI: Node 14 (end of life since 2023) -> Node 20, actions v4, npm ci with the existing lockfile. - Release: builds on keploy#114. Adds registry-url so setup-node writes the npm auth config (without it NODE_AUTH_TOKEN is ignored and publish fails), and takes the version from the release tag so npm always matches a tagged commit. - package.json: 2.0.2 -> 2.0.10, the version already on npm (published from a063214).
slayerjain
added a commit
that referenced
this pull request
Oct 31, 2026
…mits and tag-only releases given() posts to /agent/scope/given, which keploy/keploy#5016 adds and no keploy release serves yet. On a keploy without it, the error said "use a keploy and a @keploy/playwright of the same release", and no such release exists. It now says what happened and what is needed: keploy: this keploy agent answered 404 to POST /agent/scope/given, so it cannot take the given value <name>: given needs a keploy that serves that route, which keploy/keploy#5016 adds Claim, begin, settle and end work with released keploy, so the package is usable without given. README: - Limits: given's route (with the error above), and the third limit the package has: the beforeAll and afterAll hooks of a group whose tests are all set aside still run, because each test is skipped at its own begin. - Releasing: bump the version in a pull request, then push playwright-vX.Y.Z as a plain git tag on main. Never create a GitHub release for it: a published release starts every workflow of the repository that runs on releases, such as the root @keploy/sdk release workflow of #117, which would try to publish under the tag's name. The publish workflow's header says the same. - Run the suite with --retries=0 as well as --workers=1, with the reason. Signed-off-by: slayerjain <shubhamkjain@outlook.com>
Member
|
Closing this as covered by what is on main now:
Thanks for the groundwork here: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
@keploy/sdkon npm is 2.0.10 (published 2024-07-23 from a063214), butpackage.jsononmainstill says 2.0.2, so the repo doesn't say which version is live.actions/checkout@v2andsetup-node@v2.setup-nodegets noregistry-url, so it writes no npm auth config andNODE_AUTH_TOKENis ignored atnpm publish. It also publishes whatever version is inpackage.json, so a release tag and npm can drift again.The package is still in use (about 4,300 downloads in the last 30 days) and the v4 Node quickstarts in keploy/docs install it.
Change
ci.yml: Node 20,actions/checkout@v4,actions/setup-node@v4with npm cache,npm ci+npm run buildon the existing lockfile (the repo haspackage-lock.json, not a yarn lock). Commitlint step unchanged.release.yml(builds on ci: add a github actions for publishing to npm #114 by @Sarthak160): runs on a published GitHub release, setsregistry-urlso the token is used, sets the package version from the release tag (v2.0.11->2.0.11), thennpm ci, build, andnpm publish --provenance --access public. Needs anNPM_TOKENrepo secret.package.json/ lockfile: version 2.0.2 -> 2.0.10, matching npm.Verified locally
npm ci && npm run buildon a clean checkout: passes.v2.0.11->npm versionsets 2.0.11.If this lands, #114 can be closed.