Finish the local browser import experience - #233
Draft
IlyaasK wants to merge 18 commits into
Draft
Conversation
Reuse dashboard-created imports with fresh scoped helper grants, report profile and Managed Auth results, and wait for dashboard acknowledgement. Close only the exact connector-created Terminal tab after a successful handoff while leaving failures visible.
Return from the kernel URL handler immediately and delegate bounded success monitoring to a detached process, so an interrupted import cannot prevent later deep links from opening Terminal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This is the CLI finished-experience layer for KERNEL-1975.
Why
The customer must understand how many Managed Auth connections their plan permits and must see that a multi-minute server apply is progressing. Once the API owns durable post-import authentication, the local CLI should not remain open while that background queue runs.
How
max_auth_connectionsandauth_connections_usedorganization-limit fields exposed by the current API/SDKfinishing_managed_authas a successful dashboard handoff phaseThe latest published Go SDK does not yet expose
connections_usedon/org/entitlements; using the generated/org/limitsfields avoids a hand-written HTTP path while preserving the merged entitlement values.Deployment
Stacked on #229. Merge only after kernel/kernel#3453 is deployed, then publish and verify the Homebrew CLI before enabling the dashboard consumer.
Verification
go test ./cmd ./internal/browserimport -run 'Test(ProfileImportProgress|ManagedAuth|ChooseManagedAuth|DecodeManagedAuth|ClientRunsDashboardHandoff)' -count=1go vet ./cmd ./internal/browserimportfinishing_managed_authgit diff --check browser-import/04-profile-data..browser-import/05-finished-experience