Repository navigation
Ship third-party notices in the browser images - #512
Merged
Merged
Conversation
Contributor
Author
|
Picked tnsardesai to review these related PRs (kernel/oss-source#1, #512): touched the changed code in |
tnsardesai
approved these changes
Nov 9, 2026
|
|
||
| 1. CHROMIUM | ||
| ----------- | ||
| This image runs a Chromium build: Chrome for Testing 155.0.8059.84 in the |
Contributor
There was a problem hiding this comment.
Do we need to keep this version in sync
| ffprobe alongside it, used by the session recorder. It is a separate program: | ||
| nothing in Kernel's software links against it. | ||
|
|
||
| version: n7.1.5-12-g1fdbca85aa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
/usr/share/doc/kernel/THIRD-PARTY-NOTICES.txtto both browser images, copied in fromshared/legal/.Customers can read it without a shell, via
read_fileon that path orcatthrough exec.What it covers:
chrome://credits, and the two LGPL-2.0-or-later Blink files that our build modifies/usr/share/doc/<pkg>/copyrightand the archivefonts-urw-base35: AGPL-3.0 with font exception, noted explicitlyDepends on:
kernel/oss-sourcegoing public. The notices file points athttps://github.com/kernel/oss-sourceand its FFmpeg release; while that repo is private the links resolve only for org members, so this should not ship until it is public.Not in scope here: the same file needs adding to
kernel-images-private, which has its own Dockerfiles. Happy to follow up with that PR once this lands so the wording settles.