Repository navigation
Add create_live_view action to manage_browsers - #273
Closed
masnwilliams wants to merge 3 commits into
Closed
masnwilliams wants to merge 3 commits into
masnwilliams wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
masnwilliams
marked this pull request as ready for review
November 12, 2026 20:05
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Collaborator
Author
|
Superseded by #262, the coverage bot's 0.148.0 update, which adds the same |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
create_live_viewaction tomanage_browsers. It callsPOST /browsers/{id_or_name}/live_view(client.browsers.liveView.create) and returns a live view URL scoped to read-only or control access.live_view_scope(read|control, API defaultread) andlive_view_ttl_seconds(1 to 31,536,000; omit to keep the URL valid until the browser is deleted). They are only accepted withcreate_live_view; other actions reject them the same way creation-only params are rejected.url,scope,expires_atwhen set) plus a short note that the URL opens only the live view and cannot be revoked before it expires.maxRetries: 0, since a retry after a lost response would mint a second URL that can't be revoked.session_iddescriptions list the new action.This extends the existing browser tool instead of adding a new one, so the tool list is unchanged.
Bumps
@onkernel/sdkto 0.148.0, the first release withbrowsers.liveView.create.Testing
session_idis required; live view params are rejected on other actions.bun test(1193 tests) andtsc --noEmitpass on 0.148.0.