Skip to content

Check the date of the flight in the Delta cart - #147

Closed
yummybomb wants to merge 1 commit into
mainfrom
hypeship/delta-cart-date-check
Closed

yummybomb wants to merge 1 commit into
mainfrom
hypeship/delta-cart-date-check

Conversation

@yummybomb

Copy link
Copy Markdown
Contributor

Summary

delta-cart-main-classic is graded from the Trip Summary page the agent leaves: route, cabin, passenger count and amount due. It did not check the date, so a cart holding a Main Classic ATL to MCO fare on the wrong day passed.

  • The check now needs Trip Summary's Journey date line to carry the date the task asked for.
  • Delta shows that date without its year (Thu, Dec 10), so a relative fixture date can resolve to that form: {"days_from_start": 28, "format": "month_day"} gives Dec 10. The ISO form the prompt uses is unchanged.

The rule accepts the date on the label's line or the next one, with or without a weekday or year around it.

Not changed

Flight numbers are still not compared with the page. extract reads one value per pattern and same_as_answer compares sets, so a connecting itinerary would fail a correct answer; that needs a multi-value extract first. Whether the fare is the cheapest is still left to agreement.

Testing

  • node --test "bench/**/*.test.mjs": 131 passed. The new test grades the real intent against Trip Summary's visible text for one flight, and fails it when the task asked for another day (Dec 11, and Dec 1 against Dec 10).
  • node scripts/validate-registry.mjs
  • Rehearsed once on the live site: a stealth Kernel browser, the pinned Delta tool batch, ATL to MCO 28 days out, Main Classic. The full Trip Summary text passed the whole check with the new rule, and failed it with the fixture moved a day.
  • Only Delta's /purchase/flights/trip-summary page was seen. The older /completepurchase/ page the check also accepts was not, and no paired bench run was made.

The delta-cart-main-classic check passed a cart holding the right route,
cabin and total on the wrong day. It now needs Trip Summary's journey date
to be the date the task asked for.

Delta shows the date without its year, so a relative fixture date can
resolve to that form with "format": "month_day".
@yummybomb

Copy link
Copy Markdown
Contributor Author

Closing: not wanted. The benchmark changes are in kernel/benchmarks#13.

@yummybomb yummybomb closed this Nov 12, 2026
@yummybomb
yummybomb deleted the hypeship/delta-cart-date-check branch November 12, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant