Skip to content

build: update Go to 1.27.4 for net/http security fix - #32

Merged
kongesque merged 1 commit into
mainfrom
chore/go-1.27.4
Nov 16, 2026
Merged

kongesque merged 1 commit into
mainfrom
chore/go-1.27.4

Conversation

@kongesque

Copy link
Copy Markdown
Owner

Summary

The main push after #30 failed CI on the govulncheck step (./scripts/security-check.sh), not on tests. GO-2026-6859, published on 2026-11-11, affects net/http in Go 1.27.3 and is fixed in Go 1.27.4. Every new CI run on 1.27.3 fails the same way.

This moves the reviewed toolchain from Go 1.27.3 to 1.27.4 everywhere it is pinned, the same 17 files as the 1.27.3 update (d6e71cd):

  • go.mod, scripts/check-toolchain.sh, and the cli.yml / cli-release.yml setup-go pins.
  • Build requirements in AGENTS.md, the READMEs and CLI guides (en/ja/th/zh-TW), DEVELOPMENT.md, and SESSION.md.
  • A dated SECURITY.md entry and a changelog Security entry under Unreleased.

Applicability

The advisory is a crash in HTTP/1 servers that use MaxBytesReader or MaxBytesHandler. The CLI runs no HTTP server (no http.Server, Serve, or MaxBytesReader outside tests), but govulncheck reports the patched net/http symbols as reachable from the HTTP client calls. The project uses no advisory exemptions, so the toolchain is updated instead. Existing release binaries need a rebuild (the next release) to pick it up.

Validation

On macOS arm64 with official Go 1.27.4 (checksum verified):

  • ./scripts/check-toolchain.sh, ./build.sh, ./bin/line help.
  • ./scripts/security-check.sh ./bin/line (govulncheck v1.9.0): source and binary scans report 0 reachable vulnerabilities; 5 module-only findings in code the CLI does not call, unchanged.
  • go test -race ./internal/... ./cmd/line ./pkg/line/... ./pkg/e2ee, go test ./pkg ./pkg/ltsm, go vet, staticcheck, gofmt, git diff --check.
  • Windows and Linux run in CI.

go mod tidy -diff reports that golang.org/x/crypto would move into the main require block. That predates this change and is left alone.

🤖 Generated with Claude Code

GO-2026-6859 (published 2026-11-11) affects net/http in Go 1.27.3 and is
fixed in Go 1.27.4. The CLI runs no HTTP server, but govulncheck reports
the patched symbols as reachable, so the security scan fails every CI run
on 1.27.3. Update the module, compiler guard, CI and release pins, build
requirements, and the security record together.
@kongesque
kongesque merged commit 4b0a638 into main Nov 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant