Repository navigation
build: update Go to 1.27.4 for net/http security fix - #32
Merged
Merged
Conversation
GO-2026-6859 (published 2026-11-11) affects net/http in Go 1.27.3 and is fixed in Go 1.27.4. The CLI runs no HTTP server, but govulncheck reports the patched symbols as reachable, so the security scan fails every CI run on 1.27.3. Update the module, compiler guard, CI and release pins, build requirements, and the security record together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
mainpush after #30 failed CI on the govulncheck step (./scripts/security-check.sh), not on tests. GO-2026-6859, published on 2026-11-11, affectsnet/httpin Go 1.27.3 and is fixed in Go 1.27.4. Every new CI run on 1.27.3 fails the same way.This moves the reviewed toolchain from Go 1.27.3 to 1.27.4 everywhere it is pinned, the same 17 files as the 1.27.3 update (d6e71cd):
go.mod,scripts/check-toolchain.sh, and thecli.yml/cli-release.ymlsetup-go pins.Applicability
The advisory is a crash in HTTP/1 servers that use
MaxBytesReaderorMaxBytesHandler. The CLI runs no HTTP server (nohttp.Server,Serve, orMaxBytesReaderoutside tests), but govulncheck reports the patchednet/httpsymbols as reachable from the HTTP client calls. The project uses no advisory exemptions, so the toolchain is updated instead. Existing release binaries need a rebuild (the next release) to pick it up.Validation
On macOS arm64 with official Go 1.27.4 (checksum verified):
./scripts/check-toolchain.sh,./build.sh,./bin/line help../scripts/security-check.sh ./bin/line(govulncheck v1.9.0): source and binary scans report 0 reachable vulnerabilities; 5 module-only findings in code the CLI does not call, unchanged.go test -race ./internal/... ./cmd/line ./pkg/line/... ./pkg/e2ee,go test ./pkg ./pkg/ltsm,go vet,staticcheck,gofmt,git diff --check.go mod tidy -diffreports thatgolang.org/x/cryptowould move into the mainrequireblock. That predates this change and is left alone.🤖 Generated with Claude Code