You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looks good — approve-equivalent, nothing blocking. Docs-only (CLAUDE.md, +6/-0); no Go files touched, so go build / go vet / go mod tidy checks aren't applicable to this diff.
What changed since the earlier rounds
The block landed in the right place and the earlier substantive concerns are resolved:
✅ Moved out of ### Principles (slice-granularity list) into ## Working Style: TDD, directly after the loop — where cleanup guidance belongs.
✅ Also make sure to: is now its own lead-in sentence rather than being grammatically glued to "…then commit any remaining cleanup", so the bullets read as standing rules instead of post-commit steps.
✅ Bullets use - to match the other 45 bullets in the file.
✅ The double-em-dash is gone — not *what*; the code already says… now separates the two independent clauses cleanly.
✅ Repeat steps 2–7 is accurate again (the loop is back to 7 steps).
✅ Carving out godoc comments on exported identifiers is the right call — a blanket "minimal comments" rule would otherwise fight Go convention and golint-style expectations.
Hard wrap — CLAUDE.md:119-121 wraps at ~95 chars; every other bullet/paragraph in the file is a single unwrapped line, making this the only wrapped block in the document.
Repeated verb — "Follow good practices — follow industry practices…"; the useful half is "the patterns already established in this codebase".
Neither affects how Claude reads the file. Merge as-is if you'd rather stop iterating.
One thing worth considering
## Working Style: TDD scopes these rules to the TDD loop. Since "keep comments minimal" and "follow existing patterns" apply to all work in this repo (doc edits, config, one-off fixes), a top-level ## Code Style section would be marginally more discoverable. Given the file is read whole on every session, this is a stylistic preference, not a functional gap. Fix this →
Note: the checked-out working tree had this change reverted locally (M CLAUDE.md) — a runner artifact; I did not commit anything. Review is against the pushed commit b678f83.
· 20260829_claude_comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instruct Claude to not use excessive code comments
Checklist
charts/k8s-reporter/) updated, if needed. Note: these changes live in a separate PR