Skip to content

fix(docs): help typos - #1142

Merged
mbevc1 merged 2 commits into
mainfrom
20260830_fix_typos
Aug 30, 2026
Merged

fix(docs): help typos#1142
mbevc1 merged 2 commits into
mainfrom
20260830_fix_typos

Conversation

@mbevc1

@mbevc1 mbevc1 commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Minor typo fixes.

Checklist

@github-actions github-actions Bot added the go Pull requests that update go code label Aug 30, 2026
@mbevc1
mbevc1 enabled auto-merge (squash) August 30, 2026 17:57
@github-actions github-actions Bot added the fix label Aug 30, 2026
@claude

claude Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Claude finished @mbevc1's task in 1m 39s —— View job


Review — PR #1142 fix(docs): help typos

  • Read PR diff and commits
  • Run static checks (go build, go vet, go mod tidy)
  • Check for remaining typos / doc regeneration needs
  • Post review

Verdict: LGTM ✅

Pure documentation-string change — three instances of overridenoverridden, plus the capitalization nit from my previous pass. No behavioural change, no test impact.

Static analysis

Check Result
go build ./... ✅ pass
go vet ./... ✅ pass
go mod tidy + git diff --exit-code go.mod go.sum ✅ clean

Changes reviewed

cmd/kosli/attestSonar.go (long help text, lines 42 & 51) — both overridenoverridden. Correct: override is a two-syllable-stress verb, so the past participle doubles the d.

cmd/kosli/root.go:300overridenoverridden, and sonar scannerSonar scanner. Thanks for picking up the follow-up nit; sonarWorkingDirFlag now matches the Sonar scanner casing used throughout attestSonar.go, so the flag help and the command long-help read consistently.

Verification

  • Grepped the whole repo (not just .go) for overridenzero remaining occurrences. Also checked a handful of adjacent common misspellings (occured, seperate, recieve, dependant, paramater, existance, compatable) — all clean.
  • Checked testdata/ for golden files containing this help text: the only hit is cmd/kosli/testdata/empty-flag-audit-coverage.json:467, which stores the flag name ("sonar-working-dir"), not its description. No golden files need regenerating.
  • No generated CLI docs are checked into the repo (docs/ holds only ADRs and handover notes), so the docs checklist item is satisfied by the help-text edit itself.

Nits / risks

None. Nothing to flag on quality, edge cases, bugs, security, or performance — the diff touches only string literals used for help output.

Nice work

Small, focused, single-purpose diff that's trivially reviewable — exactly the "thin vertical slice" shape CLAUDE.md asks for. Also good that you fixed all three occurrences of the same misspelling in one pass rather than leaving the codebase half-corrected, and took the consistency nit on the line you were already touching.
· branch 20260830_fix_typos

Comment thread cmd/kosli/root.go Outdated
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
@mbevc1
mbevc1 merged commit 775b232 into main Aug 30, 2026
22 checks passed
@mbevc1
mbevc1 deleted the 20260830_fix_typos branch August 30, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants