Repository navigation
Conversation
Contributor
|
Claude finished @tooky's task in 1m 5s —— View job PR review
No blocking issues; LGTM. The SBOM bundle example at I left two optional nits in the review comment:
|
tooky
marked this pull request as draft
November 14, 2026 15:05
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1377, which tied the default GitHub signer for
kosli attest in-tototo the current run and pinned the help examples to a workflow file and its ref. A signer regexp that accepts any workflow on any ref lets anyone who can push a branch produce an attestation that records asverified: true.The SBOM bundle example still accepts any signer under the repository URL. The CLI reference is generated from this help text, so that is what users copy. This PR changes only that example, in
cmd/kosli/attestInToto.go:The new value is the one the neighbouring provenance example uses. No other help text, sample workflow or doc in the repo has a regexp that accepts any workflow or any ref. The regexps in
hack/empty-flag-audit/spec.jsonare audit fixtures, not examples, so they're unchanged. Command behaviour doesn't change.Evidence
kosli attest in-toto --helpnow shows the SBOM example with--certificate-identity …/.github/workflows/build.yml@refs/heads/main, matching the other examples.Merge Danger
Door: two-way. It's a one-line help-text change.
Blast Radius: the generated CLI reference page for
kosli attest in-toto, and nothing at runtime.