security: fix stored XSS in activities and notes rendering - #2466
security: fix stored XSS in activities and notes rendering#2466bhavesh-018 wants to merge 2 commits into
Conversation
|
Hi @bhavesh-018 , Thank you for implementing the fix for this issue (#2419). The changes look good, especially the removal of unsafe rendering (v-html / v-safe-html) and the shift to escaped output. I’ll validate the fix from my side once it is merged or if a test instance is available. Please feel free to let me know if any additional testing or verification is required. Also, I would appreciate being credited in the security advisory or release notes for reporting this vulnerability. Thanks again for the quick turnaround. Best regards, |
|
Hi @Dineshrajansv Thanks again for the detailed report and collaboration. |
|
@Dineshrajansv |
|
Hi @bhavesh-018, I validated the patch locally using the same payload: <script>alert('XSS')</script>The script is now rendered as plain text and no JavaScript execution occurs. Thanks for addressing the issue. Best regards, |
Issue Reference
Fix #2419
Description
This pull request mitigates a Stored Cross-Site Scripting (CWE-79) vulnerability in the Activities module.
User-controlled input in activity comments was previously rendered using dynamic HTML injection (
v-html/v-safe-html), allowing execution of malicious JavaScript.Changes made:
User-supplied content is now displayed as plain text, preventing script execution.
How To Test This?
<script>alert('XSS')</script>Expected Result:
Documentation
Branch Selection
Tailwind Reordering
All Tailwind classes remain unchanged except for rendering adjustments.