Repository navigation
Refactor RO CLI tests into shared-UAI lifecycle recordings - #7
Merged
krtcodee merged 1 commit intoNov 13, 2026
Conversation
Replace per-operation scaffolding with four native recorded lifecycles, reproducible shared-fixture setup, and isolated Playback coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d8a0519-e0d0-4ee2-b065-14ff84798018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the RecoveryOrchestration CLI tests into the lifecycle-oriented style used by Drills, addressing the feedback in Azure/azure-cli-extensions#10530.
RECOVERY_PLAN_SETUP.md, documenting manifest/environment inputs, permissions, cleanup and precise coverage.Only RO tests, their setup documentation/scripts and recordings change. No generated commands, product code, Drills/Goals tests or PowerShell changes.
Native scenarios
test_recovery_plan_crud_identity_lifecycletest_recovery_plan_shared_uai_success_lifecycletest_recovery_plan_shared_uai_resume_lifecycletest_recovery_plan_shared_uai_retry_lifecycleRetry is independent of Resume because its intentionally failing prerequisites differ from the successful manual-resume flow. No product responses, job states or recordings were fabricated or stitched.
Fixture and cleanup
Live execution uses existing approved service groups and workload resources, an existing Automation account, a published success runbook and a published pure-failure Python3 runbook. One shared UAI has Automation Job Operator and Reader on the account plus Reader on the selected storage resource.
The setup scripts run separately from scenario recording; individual tests do not create or enumerate RBAC grants. Each scenario creates and deletes its own plan, without deleting shared identities, grants, runbooks or service groups. Native deletion/absence and exact shared-UAI/grant persistence were verified. Six fresh owned plans were created sequentially and deleted during validation.
Validation
Coverage boundaries
SAI assignment remains reassignment of an existing SAI, not initial None-to-SAI. Identity wait verifies its completion predicate, not a deliberately prolonged transition. Finalize is Ready-state revalidation, not Warning-to-Ready. Retry proves another numbered attempt on the same failed job, not successful recovery or an unverified script-specific failure cause. Regional and additional identity variants are not claimed.