Repository navigation
Add CompatibilitySuppressions.xml to Color, Cpp, Music and Strings.Identifiers [patch] - #519
Merged
Merged
Conversation
…entifiers [patch] These four projects multi-target and compile Polyfill shims, but unlike Strings, Paths and Quantities they had no suppression file, so package validation failed the Release step with CP0014/CP0015 on the shim types (ExperimentalAttribute.UrlFormat, DefaultInterpolatedStringHandler) between adjacent TFMs. Generated with -p:ApiCompatGenerateSuppressionFile=true; every entry is a System.* shim and none names a ktsu.* type. Each csproj gets the same explanatory comment Semantics.Strings carries. Fixes #517 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW2KAa6zCGcN4V3T7ea
|
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #517
What changed
This follows the issue's suggested fix, which is what Strings, Paths and Quantities already do.
CompatibilitySuppressions.xmlforSemantics.Color,Semantics.Cpp,Semantics.MusicandSemantics.Strings.Identifierswith-p:ApiCompatGenerateSuppressionFile=true.System.Diagnostics.CodeAnalysis.ExperimentalAttribute(includingUrlFormatand its accessors) andSystem.Runtime.CompilerServices.DefaultInterpolatedStringHandler(the type, its.ctorandAppendFormatted). No entry names aktsu.*type.Semantics.Strings.csproj, including how to regenerate the file.Verification
Run locally on SDK 10.0.403, for each of the four projects:
mainbin/obj)ktsu.Semantics.Color.6.0.0.nupkgktsu.Semantics.Cpp.6.0.0.nupkgktsu.Semantics.Music.6.0.0.nupkgktsu.Semantics.Strings.Identifiers.6.0.0.nupkgThe error counts on
mainmatch the ones in the issue.Tests:
dotnet test --project Semantics.Test: 1962 passed, 14 skipped, 0 failed.dotnet test --project Semantics.Cpp.Test -f net10.0: 45 passed. This container has no .NET 9 runtime, so the net9.0 leg could not run here.I didn't look into the KtsuBuild 2.19.2 → 2.19.3 question the issue raises. As the issue says, the suppressions are correct either way.
Generated by Claude Code