You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs(benchmark): point the adapter tests link at a revision that has them - #1100
The "Adapter behavior tests" link in benchmark/ttlcache-expiration.md was pinned to 349273d, which is older than TestSetReclaimsOneExpiredEntry and TestRenewalChangesExpirationOrder. This points it at 7d71f56 (the merge of #1098), where both tests exist. The other links to 349273d point at the original evaluation and methodology docs, so I left them as they are.
How to Test
Open the updated link and check that cache_test.go at that revision has both tests (lines 151 and 171).
…them
The Adapter behavior tests link in benchmark/ttlcache-expiration.md
pinned 349273d, which predates TestSetReclaimsOneExpiredEntry and
TestRenewalChangesExpirationOrder. Point it at 7d71f56, the merge of
the adapter change, which contains both tests.
Signed-off-by: KVR Vishnu <46535652+VISHNU0906@users.noreply.github.com>
No actionable comments were generated in the recent review.
Walkthrough
The TTL expiration benchmark documentation now links to commit 7d71f56924b18bf00884fa7798b6090b5323e737 for the adapter behavior tests. The surrounding description is unchanged.
Changes: Benchmark documentation
Layer / File(s)
Summary
Update the behavior-test link benchmark/ttlcache-expiration.md
The link now points to commit 7d71f56924b18bf00884fa7798b6090b5323e737.
This updates a documentation link to point at a revision containing the cited adapter behavior tests. It has no production impact and is ready to merge.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title says the PR points the adapter tests link at a revision that contains those tests. The raw summary confirms that the only change in benchmark/ttlcache-expiration.md is the test link's commit…
Linked Issues check
[#1099] requires the "Adapter behavior tests" link in benchmark/ttlcache-expiration.md to point to a revision that contains TestSetReclaimsOneExpiredEntry and TestRenewalChangesExpirationOrder. At hea…
Out of Scope Changes check
The whole-PR change is a single-line edit in benchmark/ttlcache-expiration.md that replaces the commit in one link (349273d to 7d71f56). This edit directly implements #1099. The head file still link…
Full details: Title check
Explanation
The title says the PR points the adapter tests link at a revision that contains those tests. The raw summary confirms that the only change in benchmark/ttlcache-expiration.md is the test link's commit hash, moved from 349273d to 7d71f56. The PR objectives say this new revision is the merge of #1098 and contains TestSetReclaimsOneExpiredEntry and TestRenewalChangesExpirationOrder, which matches the title's purpose. The title is specific and describes the single change. Its 'docs(benchmark):' prefix is a conventional-commit style scope and does not affect the assessment.
Full details: Linked Issues check
Explanation
[#1099] requires the "Adapter behavior tests" link in benchmark/ttlcache-expiration.md to point to a revision that contains TestSetReclaimsOneExpiredEntry and TestRenewalChangesExpirationOrder. At head, that link targets commit 7d71f56 at internal/ttlcache/cache_test.go. Reading that path at the merge base (7d71f56, the same commit) shows both test functions present. The file read did not report line numbers, so the claimed lines 151 and 171 were not verified exactly. The requirement is a revision that contains the tests, and that is met. The whole-PR diff tool was unavailable. The check relies on the head file read and the supplied change summary (+1/-1 in one file), which is consistent with the head content. This is a non-coding documentation link fix, so the coding requirement is satisfied only by the link target containing the required tests, which it does.
Full details: Out of Scope Changes check
Explanation
The whole-PR change is a single-line edit in benchmark/ttlcache-expiration.md that replaces the commit in one link (349273d to 7d71f56). This edit directly implements #1099. The head file still links other evidence to 349273d (the original evaluation, process-tree constructor, and methodology links), which matches the PR description's stated intent to leave those unchanged. No unrelated files or hunks were identified in the supplied summary. The diff tool was unavailable, so completeness relies on the supplied summary of +1/-1.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: da062c26-39e0-483e-8d02-47bea934a6e9
Commits
Reviewing files that changed from the base of the PR and between 7d71f56 and ed7e280.
Files selected for processing: 1
benchmark/ttlcache-expiration.md
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
Reviewed head ed7e2804602e2b423880643ea6e330fed9e1d32d against main at 7d71f56924b18bf00884fa7798b6090b5323e737.
This change is needed for #1099: the previous link target 349273dd does not contain TestSetReclaimsOneExpiredEntry or TestRenewalChangesExpirationOrder; the new target contains both (verified in internal/ttlcache/cache_test.go). The diff changes only this benchmark documentation link and does not affect runtime behavior.
History: the stale-link concern originated as an inline CodeRabbit comment on merged #1098 and is tracked by #1099. Related #1018/#1098 discussions raised performance and workload blockers for the experimental cache; those were addressed before merge, and production remains on Hashicorp, so those findings do not block this documentation-only correction. Searches for TTL-cache/expiration PRs and issues found #1018, #1098, #1099, and #1014; indexed search is bounded and not exhaustive. No duplicate or superseding fix was found.
No blockers or nonblocking follow-ups remain for this PR. All checks passed, including the gated Go build/unit workflow, component-test matrix, benchmark, CodeQL, CodeRabbit, DCO, and GitGuardian. The test target was verified directly; no separate local test run was needed for this link-only change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The "Adapter behavior tests" link in
benchmark/ttlcache-expiration.mdwas pinned to 349273d, which is older thanTestSetReclaimsOneExpiredEntryandTestRenewalChangesExpirationOrder. This points it at 7d71f56 (the merge of #1098), where both tests exist. The other links to 349273d point at the original evaluation and methodology docs, so I left them as they are.How to Test
Open the updated link and check that
cache_test.goat that revision has both tests (lines 151 and 171).Related issues
Fixes #1099
cc @matthyx
Summary by CodeRabbit