Repository navigation
Upgrade to Python 3.12 base layer - #9
Merged
Merged
Conversation
- Base image baseevalutionfunctionlayer:main-3.8 -> main-3.12 (AL2023: dnf findutils, PYTHONPATH, pytest for healthcheck, module-style CMD) - numpy==1.21.2 -> numpy>=1.26 (no Python 3.12 wheels for 1.21) - Workflows copied from survey: Python 3.12, deploy.yml@main, PR-triggered test-lint, database tests on production deploy; staging/production target master (default branch) - Add pytest.ini Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves off
baseevalutionfunctionlayer:main-3.8(Python 3.8 runtime, deprecated; the base layer has stopped building the 3.8 image).app/Dockerfile:main-3.12, the same recipe as survey (dnf findutils,PYTHONPATH=/app, pytest,CMD ["app.handler"])numpy==1.21.2changed tonumpy>=1.26, because 1.21 has no Python 3.12 wheelsdeploy.yml@maininstead of@deploy-request/@deploy-request-on-dev(main already contains everything from both),test-lintruns on PRs, andrun-database-tests: trueon production deploymaster(the repo's default branch; it used to trigger onmain). The productionbranchinput now defaults tomasterpytest.iniand updated the README Python versionTesting (branch deployed to staging; not tested locally):
tests_passed: true; eval output identical to prod[0,0,0,0,1,0],atol=0, rtol=0) but the stored grade is False. Not a regression: the function code is unchanged, and numpy 1.26 vs 1.21 can't change the result of comparing identical integer arrays. Excluding that ID only surfaced another record of the same kind on rerun, so it's left as-isTEST_API_ENDPOINTrepo secret set to thearrayEqual-stagingURL sopre_production_tests.ymlworks🤖 Generated with Claude Code