Repository navigation
Upgrade to Python 3.12 base layer - #5
Merged
Merged
Conversation
- Base image baseevalutionfunctionlayer:main-3.8 -> main-3.12 (AL2023: dnf findutils, PYTHONPATH, pytest for healthcheck, module-style CMD) - Rename evaluation_test.py -> evaluation_tests.py so the base layer healthcheck can import it - Workflows copied from survey: Python 3.12, deploy.yml@main, PR-triggered test-lint, database tests on production deploy - Add pytest.ini Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves off
baseevalutionfunctionlayer:main-3.8(Python 3.8 runtime, deprecated; the base layer has stopped building the 3.8 image).app/Dockerfile:main-3.12, the same recipe as survey (dnf findutils,PYTHONPATH=/app, pytest,CMD ["app.handler"])evaluation_test.pytoevaluation_tests.py. The base layer healthcheck importsevaluation_tests, which is why prod healthcheck currently reportstests_passed: falsedeploy.yml@maininstead of@deploy-request(main already contains everything from deploy-request),test-lintruns on PRs, andrun-database-tests: trueon production deploymaster(the repo's default branch). It used to trigger onmain, so merges never reached staging. The productionbranchinput now defaults tomasterpytest.iniand updated the README Python versionTesting (branch deployed to staging; not tested locally):
tests_passedwent from false to true; eval output identical to prod"30"/"30","1"/"1"withtype: str, sent by the harness as integers) but the stored grade is False. The function code is unchanged from prod (only the Dockerfile and test file name changed), so these aren't regressions. Excluding those IDs only surfaced more records of the same kind (2 more on rerun), so they're left as-isTEST_API_ENDPOINTrepo secret set to theisExactEqual-stagingURL sopre_production_tests.ymlworks🤖 Generated with Claude Code