Repository navigation
Upgrade to Python 3.12 base layer - #10
Merged
Merged
Conversation
- Base image baseevalutionfunctionlayer:main-3.8 -> main-3.12 (AL2023: dnf instead of yum, findutils, PYTHONPATH, pytest for healthcheck, python3 for nltk downloads, module-style CMD) - Rename evaluation_test.py -> evaluation_tests.py so the base layer healthcheck can import it - Workflows copied from survey: test-lint runs on PRs, staging test job enabled (3.12), database tests on production deploy - Add pytest.ini Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The tests load word2vec_sample, wordnet, etc. (downloaded in the Dockerfile for the image), so the GitHub runner needs them too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves off
baseevalutionfunctionlayer:main-3.8(Python 3.8 runtime, deprecated; the base layer has stopped building the 3.8 image).app/Dockerfile:main-3.12, the same recipe as survey.yum install wget unzipbecomesdnf install findutils wget unzip;python -m nltk.downloaderbecomespython3 -m …; also addsPYTHONPATH=/app, pytest, andCMD ["app.handler"]Renamed
evaluation_test.pytoevaluation_tests.py. The base layer healthcheck importsevaluation_tests, which is why prod healthcheck currently reportstests_passed: falseWorkflows now match survey's:
test-lintruns on PRs (it was manual-only), the stagingtestjob is enabled on 3.12 withneeds: test(it was commented out), andrun-database-tests: trueon production deployAdded
pytest.iniand updated the README Python versionCI test jobs now download the NLTK data (
wordnet word2vec_sample brown stopwords punkt punkt_tab). Without it the tests fail withLookupError: word2vec_sample, which is probably why test-lint had been made manual-onlyTesting (branch deployed to staging; not tested locally):
tests_passed: true; eval output identical to prod (same similarity values)Origin/Origin, stored grade False), 1 payload that fails schema validation, and 5 network 503s🤖 Generated with Claude Code