Skip to content

feat(api): update API spec from langfuse/langfuse 13edd39 - #1870

Closed
langfuse-bot wants to merge 1 commit into
mainfrom
api-spec-bot-13edd39-34237252659-1
Closed

feat(api): update API spec from langfuse/langfuse 13edd39#1870
langfuse-bot wants to merge 1 commit into
mainfrom
api-spec-bot-13edd39-34237252659-1

Conversation

@langfuse-bot

@langfuse-bot langfuse-bot commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Greptile Summary

The PR adds an optional start_time optimization to the legacy single-observation lookup.

  • Exposes the keyword-only parameter on synchronous and asynchronous clients.
  • Forwards it through raw clients as the startTime query parameter.
  • Preserves unbounded lookup behavior when the parameter is omitted.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or repository-rule violations identified.

The parameter is propagated symmetrically through every affected client layer, and existing calls remain compatible because it is keyword-only, optional, and omitted from requests when unset.

Reviews (1): Last reviewed commit: "feat(api): update API spec from langfuse..." | Re-trigger Greptile

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

@claude review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

No review was started: this request came from a bot account. Manual reviews can only be requested by someone with write access to this repository. Ask a maintainer to comment @claude review, or have your automation post the comment from a user account with write access.

Tip: disable this comment in your organization's Code Review settings.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — straightforward, mechanical addition of an optional start_time parameter to the generated observations client, consistent with existing patterns in this codebase. What was reviewed: the parameter threading from ObservationsV1Client.get/AsyncObservationsV1Client.get down to the raw client's HTTP GET call; the serialize_datetime/None-fallback handling of the new startTime query param, which matches the pattern used elsewhere in this generated client.

Extended reasoning...

Overview

The diff touches two generated API client files (client.py and raw_client.py) under langfuse/api/legacy/observations_v1/, adding an optional start_time: typing.Optional[dt.datetime] = None parameter to the get methods on both sync and async, high-level and raw client classes. This is consistent with Fern-style auto-generated SDK code that mirrors an upstream OpenAPI spec change (per the PR title, syncing from langfuse/langfuse). The new parameter is forwarded unchanged from the high-level client to the raw client, and in the raw client it is serialized with the existing serialize_datetime helper and included as a startTime query parameter, falling back to None if not supplied.

Security risks

None identified. The parameter is a client-supplied datetime used purely as a query-string filter passed to the server; there's no new auth, permission, or injection-relevant logic here, and serialization uses the existing helper used throughout the generated codebase.

Level of scrutiny

Low. This is generated boilerplate code with a repetitive, mechanical pattern (new optional parameter threaded through four near-identical method bodies), matching pre-existing idioms in the file (e.g., the params={...} dict-with-None-fallback pattern is already used by other endpoints in similarly generated files). No design decisions, business logic, or critical paths are involved.

Other factors

No bugs were flagged by the automated bug hunt, and my own read of the diff found no discrepancies — the parameter is correctly typed, correctly documented, and correctly wired end-to-end (client -> raw client -> HTTP params). This is the kind of small, self-contained, pattern-following change that doesn't need a human to double check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant