Skip to content

fix: Measure synchronizer deadlines with a monotonic clock - #253

Open
beekld wants to merge 1 commit into
bklimt/SDK-3402/retry-parkingfrom
bklimt/SDK-3402/monotonic-deadlines
Open

beekld wants to merge 1 commit into
bklimt/SDK-3402/retry-parkingfrom
bklimt/SDK-3402/monotonic-deadlines

Conversation

@beekld

@beekld beekld commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The FDv2 synchronizer loop measured its deadlines against the wall clock. When the system clock stepped backwards, every pending deadline was delayed by the size of the step. If every synchronizer was parked for 5 minutes and the clock stepped back an hour, no synchronizer ran for 65 minutes.

These deadlines now use MonotonicTime, a small value class over System.nanoTime(), so changes to the system clock don't move them.

Stacked on #252.


Note

Overview
FDv2 synchronizer orchestration previously scheduled recovery, fallback, park/unpark, and FDv1 fallback TTL deadlines using wall-clock Instant. A backward system clock step could postpone those deadlines and keep sources parked or on FDv1 longer than intended.

This PR introduces MonotonicTime (backed by System.nanoTime()) and wires it through FDv2DataSource, SourceManager, and SynchronizerFactoryWithState for all internal wait/deadline logic (awaitUntil, earliest, parking, fallback end times). MonotonicTimeTest covers comparison and duration math across nanosecond counter overflow.

Reviewed by Cursor Bugbot for commit d8cd1e1. Bugbot is set up for automated code reviews on this repo. Configure here.

@beekld
beekld added this pull request to stack #254 November 6, 2026 03:27
@beekld
beekld marked this pull request as ready for review November 6, 2026 03:27
@beekld
beekld requested a review from a team as a code owner November 6, 2026 03:27
@beekld
beekld force-pushed the bklimt/SDK-3402/monotonic-deadlines branch 2 times, most recently from 7a1fa34 to 5198a56 Compare November 6, 2026 17:37
@beekld
beekld force-pushed the bklimt/SDK-3402/monotonic-deadlines branch 7 times, most recently from 3812f38 to 1d4190d Compare November 11, 2026 01:29
@beekld
beekld force-pushed the bklimt/SDK-3402/monotonic-deadlines branch from 1d4190d to d8cd1e1 Compare November 11, 2026 01:44

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants