Repository navigation
feat(sync): detach descriptor-backed sources - #1003
Merged
Merged
Conversation
This was referenced Nov 3, 2026
ctawiah
force-pushed
the
ctawiah/sync-descriptor-detach-3bbf
branch
from
November 4, 2026 19:46
9db0949 to
d1a3812
Compare
ctawiah
force-pushed
the
ctawiah/sync-descriptor-detach-3bbf
branch
2 times, most recently
from
November 4, 2026 22:26
1d4fbc5 to
fbed979
Compare
ctawiah
force-pushed
the
ctawiah/sync-descriptor-detach-3bbf
branch
from
November 4, 2026 22:52
fbed979 to
63dfb5e
Compare
ctawiah
force-pushed
the
ctawiah/sync-descriptor-detach-3bbf
branch
from
November 4, 2026 23:57
63dfb5e to
d9b2422
Compare
ctawiah
force-pushed
the
ctawiah/sync-descriptor-detach-3bbf
branch
2 times, most recently
from
November 5, 2026 01:01
bbf39d2 to
fe4e505
Compare
ctawiah
marked this pull request as ready for review
November 5, 2026 13:35
ctawiah
force-pushed
the
ctawiah/sync-descriptor-detach-3bbf
branch
from
November 6, 2026 16:47
7b1ba80 to
56eb4e2
Compare
ctawiah
force-pushed
the
ctawiah/sync-descriptor-detach-3bbf
branch
from
November 6, 2026 17:12
56eb4e2 to
82b1505
Compare
ctawiah
force-pushed
the
ctawiah/sync-descriptor-detach-3bbf
branch
from
November 6, 2026 17:39
82b1505 to
d72cb06
Compare
ctawiah
force-pushed
the
ctawiah/sync-descriptor-detach-3bbf
branch
from
November 6, 2026 18:02
d72cb06 to
57d8b84
Compare
ctawiah
force-pushed
the
ctawiah/sync-descriptor-detach-3bbf
branch
from
November 6, 2026 18:30
57d8b84 to
d9c4e91
Compare
ctawiah
force-pushed
the
ctawiah/sync-descriptor-detach-3bbf
branch
from
November 6, 2026 19:08
d9c4e91 to
2bbcfc5
Compare
ctawiah
force-pushed
the
ctawiah/sync-descriptor-detach-3bbf
branch
from
November 6, 2026 19:51
2bbcfc5 to
1527012
Compare
ctawiah
force-pushed
the
ctawiah/sync-descriptor-detach-3bbf
branch
from
November 6, 2026 20:19
1527012 to
fc0bcf6
Compare
ctawiah
force-pushed
the
ctawiah/sync-descriptor-detach-3bbf
branch
from
November 6, 2026 20:46
fc0bcf6 to
590d4f5
Compare
ctawiah
force-pushed
the
ctawiah/sync-descriptor-detach-3bbf
branch
from
November 6, 2026 21:11
590d4f5 to
65a2ef8
Compare
ctawiah
force-pushed
the
ctawiah/sync-descriptor-detach-3bbf
branch
from
November 6, 2026 21:49
65a2ef8 to
b25e493
Compare
ctawiah
force-pushed
the
ctawiah/sync-descriptor-detach-3bbf
branch
from
November 6, 2026 22:13
b25e493 to
3a7e9cb
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f1ff089. Configure here.
nkester-ld
approved these changes
Nov 9, 2026
Detach removes the descriptor and the lock row of a linked resource. It never edits or deletes the repository source. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Context
Detach must remove the descriptor state of a linked resource without touching the repository source.
What changes
Design notes
Review focus
Verification
make buildgo test ./...golangci-lint run ./...Related changes
🤖 Generated with Claude Code
Note
Overview
Detach now treats descriptor-linked variations and attachments like first-class synced resources: it removes sync-owned descriptors and sync.lock entries while leaving repository source files untouched.
Confirmation output is richer. Instead of a single “local changes will be lost” flag, detach compares managed files to their lock fingerprint and linked resources to both reference digest and projection fingerprint, surfacing “unsynced changes” when mapping, relationships, or projected content no longer match the baseline.
Discovery and cleanup cover
.ref.yaml/ descriptor paths as well as managed files. Symlinks sitting on managed paths are ignored as definitions for change warnings and resource listing, but are still removed when detaching.SyncedAttachmentgains aFingerprint()helper aligned with how locks record linked vs managed attachments.Reviewed by Cursor Bugbot for commit 2613913. Bugbot is set up for automated code reviews on this repo. Configure here.