Repository navigation
fix(sync): drop formatVersion from the sync manifest API - #1026
Merged
Merged
Conversation
The LaunchDarkly manifest API has no formatVersion. A read of an unwritten manifest returns no version, and a patch with the field fails with "additional properties 'formatVersion' not allowed". The client no longer sends the field or requires it in a response, and the store no longer checks it. The sync.lock file keeps its own formatVersion. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ctawiah
marked this pull request as draft
November 10, 2026 18:10
ctawiah
marked this pull request as ready for review
November 10, 2026 18:13
nkester-ld
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The LaunchDarkly sync manifest API has no
formatVersion. A read of a project and a repository source that no sync wrote yet returns{"items":[],"source":"..."}, and the client rejected it withunsupported formatVersion 0. A patch that carried the field failed with/additionalProperties additional properties 'formatVersion' not allowed. Both failures stop every first sync of a project.What changes
SyncManifesthas noFormatVersionfield, and the patch body does not send one.GetSyncManifest,PatchSyncManifest, and the manifest store no longer check a remote format version.sync.lockfile keeps its ownformatVersion, which is a local format.Design notes
Review focus
Verification
go test ./...golangci-lint run ./...TestClientReadsAManifestWithoutAFormatVersionreads an empty manifest and one with entries.TestClientPatchesSyncManifestasserts the body without the field.TestStoreLoadsAnEmptyManifestloads a project without entries beside one with entries.formatVersionreturns the schema error, and a patch without it passes the schema.Follow-up
The upserts still carried the descriptor metadata of a linked resource, which the API rejects too. A later pull request removes it.
🤖 Generated with Claude Code