Skip to content

fix: Synchronize provider state access on the state lock #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kinyoklion wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Synchronize provider state access on the state lock #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/com/launchdarkly/openfeature/serverprovider/Provider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public ProviderEvaluation<Value> getObjectEvaluation(String key, Value defaultVa

@Override
public ProviderState getState() {
synchronized (state) {
synchronized (stateLock) {
return state;
}
}
Expand All @@ -141,7 +141,7 @@ public void initialize(EvaluationContext evaluationContext) throws Exception {
// If we are ready, then set the state. Don't return, because we still need to listen for future
// changes.
if (client.isInitialized()) {
state = ProviderState.READY;
setState(ProviderState.READY);
}

var completer = new CompletableFuture<Boolean>();
Expand All @@ -155,7 +155,7 @@ public void initialize(EvaluationContext evaluationContext) throws Exception {
handleDataSourceStatus(res, completer);
});

if(state == ProviderState.READY) {
if (getState() == ProviderState.READY) {
return;
}

Expand Down
Loading