Skip to content

feat: Report provider name and version to LaunchDarkly - #51

Draft
kinyoklion wants to merge 2 commits into
mainfrom
devin/openfeature-python-wrapper-info
Draft

feat: Report provider name and version to LaunchDarkly#51
kinyoklion wants to merge 2 commits into
mainfrom
devin/openfeature-python-wrapper-info

Conversation

@kinyoklion

@kinyoklion kinyoklion commented Aug 19, 2026

Copy link
Copy Markdown
Member

The provider now identifies itself as the wrapper, so requests it makes are attributed to the OpenFeature provider rather than to the Python SDK.

  • Sets wrapper_name to open-feature-python-server and wrapper_version to the provider version
  • Uses Config.with_wrapper_information, added in python-server-sdk#501blocked until that is released
  • Raises the SDK floor to >=9.17.0, the release expected to contain that method
  • Adds ld_openfeature/version.py, kept current by release-please

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions
Implementation details

Describe the solution you've provided

self.__client = LDClient(config.with_wrapper_information(WRAPPER_NAME, VERSION))

This matches the Java and .NET providers, which derive a config from the application-supplied one:

new LDClient(sdkKey, LDConfig.Builder.fromConfig(config)
    .wrapper(Components.wrapperInfo()
        .wrapperName("open-feature-java-server")
        .wrapperVersion(Version.SDK_VERSION)).build());

The provider version comes from a new ld_openfeature/version.py, added to extra-files in release-please-config.json so the constant is bumped with each release the same way docs/conf.py already is.

Describe alternatives you've considered

An earlier revision of this PR copied the Config and assigned its name-mangled private wrapper fields, because wrapper information could only be supplied to the constructor. That depends on SDK internals, hence the SDK change instead.

Additional context

The floor of >=9.17.0 is a guess at the version that will carry with_wrapper_information (current release is 9.16.1, and the SDK change is a feat:). It needs confirming once that release goes out, and CI here will fail until then since no published SDK has the method.

Testing

test_provider_identifies_itself_as_the_wrapper asserts the client's config carries the provider's name and version, and that the config passed in by the caller is unchanged. Verified locally against the SDK branch installed from source (67 tests pass, mypy clean).

Link to Devin session: https://app.devin.ai/sessions/0c452d209ec54b068ba120b4c92b8f6c
Requested by: @kinyoklion

@kinyoklion kinyoklion self-assigned this Aug 19, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
@devin-ai-integration devin-ai-integration Bot added the devin-pr Pull request created by Devin AI label Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devin-pr Pull request created by Devin AI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant