feat: Populate OpenFeature flag metadata from the evaluation reason - #53
Draft
kinyoklion wants to merge 1 commit into
Draft
feat: Populate OpenFeature flag metadata from the evaluation reason#53kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Populates OpenFeature flag metadata with the LaunchDarkly specific parts of the evaluation result, so hooks (including the OpenTelemetry hook) can read them.
variationIndex,inExperiment,ruleIndex,ruleId,prerequisiteKey,bigSegmentsStatus.No screenshots or staging preview apply - this is a server-side library change with no UI.
Implementation details
Requirements
Describe the solution you've provided
ResolutionDetailsConverternow buildsflag_metadatafrom the LaunchDarkly reason dictionary:Each reason field is read defensively with an
isinstancecheck, since the reason is a plain dictionary, so a malformed reason cannot put an unexpected type into the metadata.variationIndexuses the same default-value check that already gatesvariant.The README gains a "Flag Metadata" section documenting the keys.
Describe alternatives you've considered
Passing the whole reason dictionary through as a single
reasonmetadata entry would be closer to the LaunchDarkly shape, butFlagMetadatavalues are scalars, so the flat keys are the only available shape.Additional context
All tests pass, including 7 new cases covering each key and the omissions.
make test/make lintcurrently fail onpoetry installonmainas well, becausepoetry.lockis out of date relative topyproject.toml- unrelated to this change.@cursor review
Link to Devin session: https://app.devin.ai/sessions/0c452d209ec54b068ba120b4c92b8f6c
Requested by: @kinyoklion