Skip to content

fix: Stop sending the payload filter from the FDv2 data system - #565

Merged
keelerm84 merged 2 commits into
feat/10.xfrom
mk/SDK-3473/fdv2-no-payload-filter
Nov 6, 2026
Merged

keelerm84 merged 2 commits into
feat/10.xfrom
mk/SDK-3473/fdv2-no-payload-filter

Conversation

@keelerm84

@keelerm84 keelerm84 commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Summary

The FDv2 backend does not support payload filtering, and the SDK already documents that payload_filter_key has no effect with the FDv2 data system and logs a warning when it is set. The FDv2 data sources still added the filter query parameter to their requests, though. They no longer do:

  • The FDv2 streaming and polling data sources, sync and async, send no filter parameter.
  • The FDv1 fallback polling requesters that the FDv2 data system uses also send no filter parameter. A fallback thus cannot change the client from the full data set to a filtered subset during a session.
  • payload_filter_key is removed from the DataSourceBuilderConfig protocol, because only the FDv2 data sources read that protocol. Config and AsyncConfig keep the option for the FDv1 data system, and the FDv2 warning stays.
  • The contract-test services no longer map dataSystem.payloadFilter. No version of the test harness sends that field. The filtering capability stays for the FDv1 tests.

Note

Overview
Stops applying payload_filter_key on FDv2 data-system HTTP requests, aligning runtime behavior with the existing docs/warning that filtering does not apply to FDv2.

FDv2 streaming and polling requesters (sync and async) no longer add a filter query parameter; they still send basis when a selector is defined. FDv1 fallback polling used inside the FDv2 data system also omits filter, so an in-session fallback cannot shrink the payload to a filtered subset.

payload_filter_key is removed from the DataSourceBuilderConfig protocol (FDv2-only consumers). Config / AsyncConfig keep the option for the legacy FDv1 data path. Contract-test harnesses no longer wire dataSystem.payloadFilter into client opts.

Adds test_payload_filter.py to assert FDv2 sources never send filter even when config sets payload_filter_key.

Reviewed by Cursor Bugbot for commit aaaba34. Bugbot is set up for automated code reviews on this repo. Configure here.

The FDv2 backend does not support payload filtering. The FDv2 streaming and
polling data sources, and the FDv1 fallback requesters that the FDv2 data
system uses, no longer add the filter query parameter. The fallback thus
cannot change the client to a filtered subset of the data.

DataSourceBuilderConfig no longer has payload_filter_key, because only the
FDv2 data sources read that protocol. Config and AsyncConfig keep the
option for the FDv1 data system.
@keelerm84
keelerm84 requested a review from a team as a code owner November 5, 2026 16:15
@keelerm84
keelerm84 merged commit 4a8702d into feat/10.x Nov 6, 2026
35 of 38 checks passed
@keelerm84
keelerm84 deleted the mk/SDK-3473/fdv2-no-payload-filter branch November 6, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants