Repository navigation
fix: Stop sending the payload filter from the FDv2 data system - #565
Merged
Merged
Conversation
The FDv2 backend does not support payload filtering. The FDv2 streaming and polling data sources, and the FDv1 fallback requesters that the FDv2 data system uses, no longer add the filter query parameter. The fallback thus cannot change the client to a filtered subset of the data. DataSourceBuilderConfig no longer has payload_filter_key, because only the FDv2 data sources read that protocol. Config and AsyncConfig keep the option for the FDv1 data system.
joker23
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The FDv2 backend does not support payload filtering, and the SDK already documents that
payload_filter_keyhas no effect with the FDv2 data system and logs a warning when it is set. The FDv2 data sources still added thefilterquery parameter to their requests, though. They no longer do:filterparameter.filterparameter. A fallback thus cannot change the client from the full data set to a filtered subset during a session.payload_filter_keyis removed from theDataSourceBuilderConfigprotocol, because only the FDv2 data sources read that protocol.ConfigandAsyncConfigkeep the option for the FDv1 data system, and the FDv2 warning stays.dataSystem.payloadFilter. No version of the test harness sends that field. Thefilteringcapability stays for the FDv1 tests.Note
Overview
Stops applying
payload_filter_keyon FDv2 data-system HTTP requests, aligning runtime behavior with the existing docs/warning that filtering does not apply to FDv2.FDv2 streaming and polling requesters (sync and async) no longer add a
filterquery parameter; they still sendbasiswhen a selector is defined. FDv1 fallback polling used inside the FDv2 data system also omitsfilter, so an in-session fallback cannot shrink the payload to a filtered subset.payload_filter_keyis removed from theDataSourceBuilderConfigprotocol (FDv2-only consumers).Config/AsyncConfigkeep the option for the legacy FDv1 data path. Contract-test harnesses no longer wiredataSystem.payloadFilterinto client opts.Adds
test_payload_filter.pyto assert FDv2 sources never sendfiltereven when config setspayload_filter_key.Reviewed by Cursor Bugbot for commit aaaba34. Bugbot is set up for automated code reviews on this repo. Configure here.