Skip to content

test: Change the file size in the override retry test so the poller sees the malformed write #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kinyoklion wants to merge 1 commit into
base: feat/overrides
Choose a base branch
from
+4 −1
Open

test: Change the file size in the override retry test so the poller sees the malformed write #576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ldclient/testing/integrations/test_file_override_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,8 +526,11 @@ def test_source_retains_last_good_data_across_malformed_edit(tmp_path, sources,
def test_source_retries_a_failed_load_without_a_change_signal(tmp_path, sources, caplog):
# The fixed content has the same size as the malformed content and the file keeps its
# modification time, so the poller sees no change. Only the automatic retry can recover.
# The initial content has a different size from the malformed content, so the poller sees
# the malformed write even where file times are coarse, as on Windows, and the two writes
# can share a modification time.
path = os.path.join(str(tmp_path), 'overrides.json')
write_file(path, '{"flagValues": {"flag1": true}}')
write_file(path, '{"flagValues": {"flag1": true, "flag2": true}}')
with caplog.at_level(logging.ERROR):
_, sink = build_source(sources, [path], lambda b: b.poll_interval(FileOverrideSourceBuilder.MINIMUM_POLL_INTERVAL))
sink.require_snapshot()
Expand Down
Loading