Repository navigation
fix: build and publish the chart when a parent build was skipped - #27
Merged
Merged
Conversation
Possible relctl commands for this Pull RequestVersion scheme: calver. The version of the release is the date of the release ( Need more help? Have a look at my repo This message was created by relctl and can be disabled by the env variable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the Release run after #25,
chart-releasesucceeded and created the draftchart/202611.3.1, butchart-buildwas skipped, so the chart was never packaged, pushed or published.chart-buildhas no status function in itsif, which means an implicitsuccess(). That checks the whole chain of ancestors:chart-releasedepends ontei-build, which is skipped when the TEI Containerfiles did not change, sochart-buildwas skipped as well.Fix
chart-buildnow uses!cancelled() && needs.chart-release.result == 'success' && needs.chart-release.outputs.release-id != ''.After merge
Merging does not release the chart by itself (no chart path changes). Delete the stale draft
chart/202611.3.1(it has no tag), then run the Release workflow manually withcomponents=chart.