Repository navigation
Conversation
I have an application that keeps failing with "driver: bad connection" and no other error or details. I'm not sure if this is wrong usage on my part, a server problem or a pq problem, but just returning driver.ErrBadConn is not exactly easy to debug. So wrap the error in cases where driver.ErrBadConn is used without returning an error. When this code was written %w didn't exist yet, but now it does and I verified that database/sql uses errors.Is(). Hopefully I have all instances of those(?) I'll run this PR and see what happens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have an application that keeps failing with "driver: bad connection" and no other error or details. I'm not sure if this is wrong usage on my part, a server problem or a pq problem, but just returning driver.ErrBadConn is not exactly easy to debug.
So wrap the error in cases where driver.ErrBadConn is used without returning an error. When this code was written %w didn't exist yet, but now it does and I verified that database/sql uses errors.Is().
Hopefully I have all instances of those(?) I'll run this PR and see what happens.