Repository navigation
CI: ignore zizmor unpinned-tools false positive on setup-just - #45
Merged
Merged
Conversation
zizmor cannot resolve ${{ env.JUST_VERSION }} and reports setup-just as
possibly installing an unpinned tool (code-scanning alerts #1, #3, #9).
Inline the literal version and drop the now-unused JUST_VERSION env var.
Claude-Session: https://claude.ai/code/session_01X16aaEYzUw6qwf6co68x5d
…stead Restore the JUST_VERSION env var next to UV_VERSION and mark the setup-just steps with an inline zizmor ignore: just is pinned via the env var, which zizmor cannot evaluate. Claude-Session: https://claude.ai/code/session_01X16aaEYzUw6qwf6co68x5d
woutervh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes code-scanning alerts #1, #3, #9 (
zizmor/unpinned-toolsonextractions/setup-just).just is pinned to 1.58.0 via
env.JUST_VERSION, but zizmor doesn't evaluate the expression and reports the tool as possibly unpinned. This adds an inline# zizmor: ignore[unpinned-tools]comment to thejust-version:line inlinting.yaml,testing.yamlandreleasing.yaml. TheJUST_VERSIONenv var stays alongsideUV_VERSION. No behaviour change.Verified locally:
zizmor --offline .github/workflows/(v1.31.1): 3 findings → none (3 ignored).https://claude.ai/code/session_01X16aaEYzUw6qwf6co68x5d