Expose SCID, HTLC bounds, shutdown state, and reserve type on Channel - #264
Merged
benthecarman merged 1 commit intoAug 31, 2026
Merged
Conversation
|
👋 Thanks for assigning @benthecarman as a reviewer! |
elnafateh
force-pushed
the
expose-channel-snapshot-fields
branch
from
August 30, 2026 11:07
0a5a8c9 to
75df152
Compare
Contributor
Author
Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #251.
Channelwas missing several fields already available onldk_node::ChannelDetails:short_channel_id,outbound_scid_alias,inbound_scid_aliasinbound_htlc_minimum_msat,inbound_htlc_maximum_msatchannel_shutdown_state(newChannelShutdownStateenum)reserve_type(newReserveTypeenum) the same kind of gapcltv_expiry_deltawas also mentioned in the issue but is already exposed viachannel_config, so it's left out here to avoid duplication.Remaining items from #251 (splice events, on-chain transaction classification, misc smaller fields) left for follow-up PRs.