Repository navigation
Conversation
Problem linkerd/linkerd2#14111 renamed the control plane container ports for Kubernetes 1.33 (admin-http became dest-admin, ident-admin, injector-admin and so on, and the viz Prometheus port became admin). The 2.19 and 2-edge docs still use admin-http: - the external Prometheus scrape config keeps only ports named admin-http, so it scrapes no control plane or service mirror metrics at all; - the federation ServiceMonitor points at a Prometheus Service port that no longer exists; - the pprof example looks up a port named admin-http and prints nothing. Solution Use the same relabeling the bundled linkerd-viz Prometheus uses since linkerd/linkerd2#15090 (keep ports ending in admin, drop linkerd-admin so proxies aren't scraped twice), point the ServiceMonitor at port admin, and use ident-admin in the debug endpoint example, linking to the port names reference. Validation Port names checked against the charts at edge-25.10.1 (2.19) and main. markdownlint passes on the changed files. Signed-off-by: Lucas Barros <lucasbarros.kam@gmail.com>
Author
|
Friendly ping. If this isn't something you want in the project, feel free to say so and I'll close it. The same goes for #2170, also from me. |
…admin-port-names Signed-off-by: Lucas Barros <lucasbarros.kam@gmail.com>
👷 Deploy request for linkerdio pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
linkerd/linkerd2#14111 renamed the control plane container ports so they are unique per pod on Kubernetes 1.33 (
admin-httpbecamedest-admin,spval-admin,policy-admin,ident-admin,injector-admin, the service mirror usessvcmi-admin, and the viz Prometheus port becameadmin). The 2.19 and 2-edge docs still useadmin-httpin three places:linkerd-controllerjob keeps only ports whose name isadmin-http, and thelinkerd-service-mirrorjob keeps onlylinkerd-service-mirror;admin-http. No container port has that name anymore, so following this page gives an external Prometheus that scrapes the proxies but none of the control plane or service mirror metrics. Nothing fails, so the data is just missing.port: admin-httprefers to a port on the viz Prometheus Service that no longer exists (it isadmin), so the ServiceMonitor has no targets.admin-httpon the identity pod prints nothing.Solution
admin, then droplinkerd-adminso proxies aren't scraped twice by the controller job. The service mirror job matches(linkerd-service-mirror|controller);.*-admin$like the chart does, which also covers the multicluster controller (ctrl-admin).admin.ident-adminin the pprof example and link to the Control Plane Port Names reference for the other components.The same change is applied to
2.19and2-edge. 2.18 and older predate the rename and are left as they are.Validation
edge-25.10.1(2.19) andmain:admin-httpmatches no control plane or viz port in either, and the new regexes keep every*-adminandadminport while excludinglinkerd-admin.markdownlint -c linkerd.io/.markdownlint.yamlpasses on the changed files.AI disclosure: written with the help of Claude Code, reviewed and tested by me.