Repository navigation
Conversation
Add the HTTP protocol detection and outbound protocol connection metrics that shipped with 2.18 to the proxy metrics reference for 2.18 and later. Fixes linkerd#1965 Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
👷 Deploy request for linkerdio pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1965
This adds the protocol detection metrics from 2.18 to the proxy metrics reference: the inbound and outbound
tcp_detect_httpresults counters and duration histograms, plusoutbound_tcp_protocol_connections_total, along with their labels. I added it to 2.18, 2.19, 2-edge and docs since they all have the same proxy.Notes
I pulled the names and label values from linkerd2-proxy (linkerd/linkerd2-proxy#3722 and linkerd/linkerd2-proxy#3733) and double checked them against the v2.294.0 proxy that shipped with 2.18. The example output in #3722 shows
h2for the result label, but the code emitshttp/2, so I went with that.